Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] fix: 리뷰, 레시피 좋아요 데드락, 동시성 이슈 수정 #474

Merged
merged 5 commits into from
Aug 17, 2023
Merged

[BE] fix: 리뷰, 레시피 좋아요 데드락, 동시성 이슈 수정 #474

merged 5 commits into from
Aug 17, 2023

Conversation

70825
Copy link
Member

@70825 70825 commented Aug 16, 2023 •
edited
Loading

Issue

✨ 구현한 기능

  • 리뷰(likeReview)랑 레시피(likeRecipe)에 비관적 락을 걸었습니다.
    • X Lock은 성능상 좋지 않으므로 레벨 4에서 스케줄러로 수정할 예정
  • 리뷰좋아요(ReviewFavorite), 레시피좋아요(RecipeFavorite)는 유니크 제약 조건 추가했습니다.
    • DB에 유니크 제약 조건 추가하면 될 것 같아요

📢 논의하고 싶은 내용

  • x

🎸 기타

  • 낙관적 락 적용시 500개 좋아요가 동시에 들어오면 50개~60개만 처리됩니다. (likeReview 기준)

⏰ 일정

  • 추정 시간 : 모름
  • 걸린 시간 : 48

@70825 70825 self-assigned this Aug 16, 2023
@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited
Loading

Unit Test Results

182 tests   182 ✔️  13s ⏱️
  99 suites      0 💤
  99 files        0 ❌

Results for commit a994b01.

♻️ This comment has been updated with latest results.

@70825 70825 force-pushed the feat/issue-329 branch 2 times, most recently from 01a4802 to ea15fa8 Compare August 17, 2023 00:11
wugawuga
wugawuga approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@wugawuga wugawuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!!!

backend/src/main/java/com/funeat/recipe/application/RecipeService.java Show resolved Hide resolved
Go-Jaecheol
Go-Jaecheol approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동시성 해결 좋아요~~!
해결하기 전 데드락 상황에 대해 궁금하신 분들은 데드락 테코톡 올라오면 7분 쯤부터 확인하시길^^

backend/src/main/java/com/funeat/review/persistence/ReviewRepository.java Show resolved Hide resolved
hanueleee
hanueleee approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@hanueleee hanueleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

역시 db마스터 수고하셨습니다아~~

@70825 70825 merged commit 5e3af45 into develop Aug 17, 2023
1 check passed
@70825 70825 deleted the feat/issue-329 branch August 17, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Go-Jaecheol Go-Jaecheol Go-Jaecheol approved these changes

@wugawuga wugawuga wugawuga approved these changes

@hanueleee hanueleee hanueleee approved these changes

Assignees

@70825 70825

Labels
🔒 BE 🐛 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 음식 아이템 리뷰에서 하트를 계속 누르면 마이너스가 됩니다!
4 participants
@70825 @Go-Jaecheol @wugawuga @hanueleee