Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 도커 파일 수정 #406

Merged
merged 2 commits into from Sep 14, 2023
Merged

chore: 도커 파일 수정 #406

merged 2 commits into from Sep 14, 2023

Conversation

HyeryongChoi
Copy link
Collaborator

📄 Summary

깃헙 워크플로우에서 #RUN yarn build:sb 여기서 터져서 다시 돌려놓으려고 해ㅇ ㅕ..
storybookjs/storybook#21886 -> 요 상황이랑 비슷한 것 같은데 해결방법을 모르겠음..

🙋🏻 More

@HyeryongChoi HyeryongChoi added this to the 5차 데모데이 milestone Sep 14, 2023
@HyeryongChoi HyeryongChoi self-assigned this Sep 14, 2023
@wonyongChoi05 wonyongChoi05 changed the title chore: 도커파일 수정 chore: 도커 파일 수정 Sep 14, 2023
wonyongChoi05
wonyongChoi05 previously approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@wonyongChoi05 wonyongChoi05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

첵스 실시간 표정 싱싱미역이요 ㅠ

iamjooon2
iamjooon2 requested changes Sep 14, 2023
View reviewed changes
frontend/Dockerfile Outdated

# nginx
FROM nginx:latest
RUN rm -rf /etc/nginx/conf.d
COPY conf /etc/nginx
COPY --from=builder /app/dist /usr/share/nginx/html
COPY --from=builder /app/storybook-static /usr/share/nginx/html/storybook
#COPY --from=builder /app/storybook-static /usr/share/nginx/html/storybook

EXPOSE 3000
CMD ["nginx", "-g", "daemon off;"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF 지켜주세요

wonyongChoi05
wonyongChoi05 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@wonyongChoi05 wonyongChoi05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

싹싹김치요~

iamjooon2
iamjooon2 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@iamjooon2 iamjooon2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyeryongChoi HyeryongChoi merged commit 539e3ae into develop Sep 14, 2023
1 check passed
@iamjooon2 iamjooon2 deleted the chore/#405 branch September 14, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamjooon2 iamjooon2 iamjooon2 approved these changes

@wonyongChoi05 wonyongChoi05 wonyongChoi05 approved these changes

@n0eyes n0eyes Awaiting requested review from n0eyes n0eyes is a code owner

@ksone02 ksone02 Awaiting requested review from ksone02 ksone02 is a code owner

Assignees

@HyeryongChoi HyeryongChoi

Labels
🐞 Bug 📚 Frontend
Projects
2023-zipgo
Status: Done
Milestone
5차 데모데이
Development

Successfully merging this pull request may close these issues.

[FE] 프론트엔드 워크플로우 수정
3 participants
@HyeryongChoi @iamjooon2 @wonyongChoi05