[럿고] 블랙잭 1단계 미션 제출합니다. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/view/OutputView.java
jeonghoon1107
suggested changes
Mar 15, 2020
| dealer.addCard(deck.popCard(INIT_CARD_SIZE)); | ||
| } | ||
|
|
||
| public Map<String, WinOrLose> generateGameResults() { |
There was a problem hiding this comment.
result라는 객체를 따로 만들어서 score과 matchResult를 가지고 있도록 하였습니다. 나중에 돈이 들어온다면 수익에 대해서도 저장하면 좋을것 같습니다! 2단계때 사용해 보겠습니다.
| } | ||
|
|
||
| private void addCardAtGamers(Gamers gamers, Deck deck) { | ||
| addCardAtPlayers(gamers, deck); |
There was a problem hiding this comment.
player와 dealer를 get으로 가져오지 않고 메시지를 전달하면 어떨까요?
There was a problem hiding this comment.
추가 카드에 대한 로직을 gamers로 옮겼습니다!! 근데 이렇게 되면 도메인에서 View를 접근하게 되는데, 다른 방법이 있을지 궁금합니다. 사실 View를 Controller에서만 사용하려고 해서 Controller에 이 로직을 넣은 것인데, 이 부분에 대해서 의견을 듣고 싶습니다!
jeonghoon1107
approved these changes
Mar 18, 2020
| private static final int ACE_HIDDEN_SCORE = 10; | ||
| private static final int DRAW_CARD_PIVOT = 21; | ||
|
|
||
| private MatchResult matchResult; |
There was a problem hiding this comment.
맨 처음 생각과 다르게 구현이 되서 놓쳤네요! 삭제했습니다!
|
|
||
| public static void printGameResults(Gamers gamers) { | ||
| printCardsResultAndScore(gamers); | ||
| printPlayersWinOrLose(gamers.generateGameResults()); |
There was a problem hiding this comment.
계산을 view에서 하지 않고 view로 넘겨주면 어떨까요?
There was a problem hiding this comment.
2단계에서 게임결과는 출력할 필요없고 수익금에 대해서만 출력해주면 되는데, 수익금에 대한 계산은 view에서 안하도록 했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
피드백 주시면 피드백 확인후에 하면서 고민되었던 부분에 대해서 DM으로 따로 질문 드리도록 하겠습니다! ㅠㅠ
항상 리뷰 해주시느라 수고하십니다! 이번에도 잘 부탁드리겠습니다.