Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1단계 - 블랙잭] 기론(김규철) 미션 제출합니다. #226
[1단계 - 블랙잭] 기론(김규철) 미션 제출합니다. #226
Changes from all commits
5aa725d
67807ba
ee1a9fe
b28bbe9
7161dc5
2ffc15c
6592e9d
6f32dec
ec380dd
65ea3ec
807fbf7
898beda
bd394f5
f7f5050
66f520b
ea9fa87
ac35b89
05827d6
8750ed4
0542747
002889e
bf87a2e
b39dc59
e4e796a
a64fdc1
3557611
f58dd8f
07a3b75
8c7ee51
e76aa89
8159fe2
afaf8e5
314393a
b3c44d5
ef0935d
0ac0ff6
8cae334
2393038
dbc2aa8
6e80286
da8abdd
3ed5fe1
c6a1387
b42b547
3f646fc
f7af5bb
5cb9d5a
d100e02
56ad261
d8586d9
ba13f67
d03126b
6ea48e5
2d334d3
2e80acc
83b7f5b
5d622a5
87a951e
4022d7d
79540cd
1268c7b
08781bb
3b9a5e5
51f79ec
178d91b
2eb9509
e8c5cc1
dc38f44
2d4c447
63786b2
860426a
10ec7f0
bee8566
ebe0b74
3e8852b
91dbac5
2a85843
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분에 대한 코멘트였습니다 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Map
을 이용하면 꺼내기 더 쉽지 않을까요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CardFactory
보다는Deck
의 일급컬렉션처럼 보이는데, 기론은 어떻게 생각하시나요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그러네요.. 객체 생성보다는 카드들을 관리하고 분배하니 일급컬렉션에 가까워보입니다.
사실상 deck의 역할을 하고 있으니 아예 네이밍을 deck으로 수정하겠습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기론은
for문
과IntStream.range()
를 어떤 기준으로 사용하시나요?(참고) for-loop 를 Stream.forEach() 로 바꾸지 말아야 할 3가지 이유
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 collection을 구할때 stream을 유용하게 사용해서 웬만한 반복문은 통일성 있게 stream으로 바꾸려고 했었습니다! 또는 코드 길이가 길어지면 코드의 길이를 줄이기 또는 indent를 줄이기 위해 사용하기도 했습니다!
forEach는
System.out.println
와 같이 단순한 출력문일때만 사용하는게 좋다고 알고 있었는데 몇몇 군데 그냥 무심코 사용했던 곳이 보이네요😭그리고
IntStream.range()
는Stream.forEach()
와 별개인줄 알았는데 같이 성능상 문제가 있었군요!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
메서드가 한 가지 일만 하고 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드를 줄이려고 욕심부리다 보니 자꾸 퇴보하는거 같네요...😂
수정했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isLose가 true면 Win을 반환하네요. 이 네이밍은 누구 기준일까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
명확한 이름이 필요하겠군요!