Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1단계 - 블랙잭] 기론(김규철) 미션 제출합니다. #226
[1단계 - 블랙잭] 기론(김규철) 미션 제출합니다. #226
Changes from 48 commits
5aa725d
67807ba
ee1a9fe
b28bbe9
7161dc5
2ffc15c
6592e9d
6f32dec
ec380dd
65ea3ec
807fbf7
898beda
bd394f5
f7f5050
66f520b
ea9fa87
ac35b89
05827d6
8750ed4
0542747
002889e
bf87a2e
b39dc59
e4e796a
a64fdc1
3557611
f58dd8f
07a3b75
8c7ee51
e76aa89
8159fe2
afaf8e5
314393a
b3c44d5
ef0935d
0ac0ff6
8cae334
2393038
dbc2aa8
6e80286
da8abdd
3ed5fe1
c6a1387
b42b547
3f646fc
f7af5bb
5cb9d5a
d100e02
56ad261
d8586d9
ba13f67
d03126b
6ea48e5
2d334d3
2e80acc
83b7f5b
5d622a5
87a951e
4022d7d
79540cd
1268c7b
08781bb
3b9a5e5
51f79ec
178d91b
2eb9509
e8c5cc1
dc38f44
2d4c447
63786b2
860426a
10ec7f0
bee8566
ebe0b74
3e8852b
91dbac5
2a85843
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deck을 static으로 생성하신 이유가 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
카드들은 52장으로 고정되어있고 한번 생성되어 만들어진 카드들은 계속 사용하니 캐싱해서 사용하면 매번 필요할때 생성하는 비용을 줄일 수 있지 않을까 생각해서 만들었습니다.
음.. 질문을 듣고 생각해보니 로또 번호와는 달리 한번 사용된 카드는 덱에서 사라지니 캐싱을 굳이 할 필요가 없어 보이기도 하네요. 그냥 생성자를 통해 게임 시작할떄 덱을 만들기만 해도 충분할 것 같아 보이네요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deck을 static을 통해 공유한다면 여러 게임이 진행될 때 Deck의 상태를 보장할 수 없어요. 또 말씀해주신 생성 비용은 (구현하신 것처럼) 카드 캐싱을 통해 줄일 수 있을 것 같네요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
결과를 구하는 로직이 여기 저기 흩어져 있어요. 결과와 관련된 로직을 Result에서 관리해볼까요?