Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2단계 - 음식점 목록] 우디(류정우) 미션 제출합니다. #56

Merged
merged 47 commits into from
Mar 15, 2023
Merged

[2단계 - 음식점 목록] 우디(류정우) 미션 제출합니다. #56

merged 47 commits into from
Mar 15, 2023

Commits on Mar 3, 2023

  1. docs: 프로젝트 실행 순서 작성

    @jw-r
    jw-r committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    d574bca View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. refactor(App): 새로운 음식점 추가 모달을 열 때 해당 form의 내용을 초기화 하도록 수정

    @jw-r
    jw-r committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    51beede View commit details
    Browse the repository at this point in the history

  2. refactor(App): filterd 오타 filtered로 수정

    @jw-r
    jw-r committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    87c89d7 View commit details
    Browse the repository at this point in the history

  3. refactor(App): 생성자에서 이벤트를 등록하는 메서드의 네이밍을 init에서 registerEvents로 변경

    @jw-r
    jw-r committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    cb9a03c View commit details
    Browse the repository at this point in the history

  4. refactor(App): 새로운 음식점을 추가할 때, 현재 선택된 카테고리와 새로운 음식점의 카테고리가 같은 경우에만 re… 

    …nder하도록 변경
    @jw-r
    jw-r committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    68894a6 View commit details
    Browse the repository at this point in the history

  5. refactor: as const 를 사용해 상수를 선언하고, 해당 상수로부터 타입을 정의하도록 변경

    @jw-r
    jw-r committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    db6afda View commit details
    Browse the repository at this point in the history

  6. refactor: Header의 렌더링, 담당하는 이벤트와 그에 대한 처리를 Header 컴포넌 트로 분리

    @jw-r
    jw-r committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    f4629b7 View commit details
    Browse the repository at this point in the history

  7. feat: filter category 타입과, filter categories 상수 추가

    @jw-r
    jw-r committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    373f30f View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. refactor(RestaurantItem): 생성자안에서 음식점을 하나씩 렌더하는 클래스로 변경

    @jw-r
    jw-r committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    a947f5f View commit details
    Browse the repository at this point in the history

  2. refactor(RestaurantList): 파일명을 RestaurantItems로 변경, 인스턴스로 생성될 때, 넘겨받은… 

    … 음식점들로 각각의 음식점을 렌더하는 클래스로 변경
    @jw-r
    jw-r committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    14386ed View commit details
    Browse the repository at this point in the history

  3. refactor: 음식점 생성 Form과 그에 관련된 이벤트들을 컴포넌트로 분리 

    생성자들의 조합으로 앱을 구현할 수 있을거라 생각했지만 그러지 못했다. 전역에서 상태를 관리한다면 가능할 것 같다는 생각이 든다
    @jw-r
    jw-r committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    f3fb776 View commit details
    Browse the repository at this point in the history

  4. refactor: 컴포넌트내 이밴트가 발동했을 때 실행되는 메서드를 직접 가지지않고 App에서 넘겨받도록 변경

    @jw-r
    jw-r committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    c57ad3a View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. feat: 상단 탭 네비게이션 html과 스타일 구현

    @jw-r
    jw-r committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    6384043 View commit details
    Browse the repository at this point in the history

  2. feat: 상단 네비게이션 탭 컴포넌트 생성, 클릭했을 때 스타일을 변경하는 기능 구현

    @jw-r
    jw-r committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    5826133 View commit details
    Browse the repository at this point in the history

  3. refactor: RestaurantItem에 cursor pointer 적용

    @jw-r
    jw-r committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    bfef8e4 View commit details
    Browse the repository at this point in the history

  4. feat: 음식점에 liked 타입 추가, liked 프로퍼티가 true인 음식점을 반환하는 기능 구현

    @jw-r
    jw-r committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    4195918 View commit details
    Browse the repository at this point in the history

  5. feat: 음식점을 생성할 때, liked 프로퍼티를 기본값 false로 추가하도록 변경

    @jw-r
    jw-r committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    870be1b View commit details
    Browse the repository at this point in the history

  6. refactor: App에 상태를 두고 상태가 변환되면 변경된 상태에 따라 음식점 목록을 렌더링하도록 변경

    @jw-r
    jw-r committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    d41d3d9 View commit details
    Browse the repository at this point in the history

  7. refactor: 카테고리, 정렬 옵션이 변하면 상태를 설정하고 렌더하는 setState를 실행하도록 변경

    @jw-r
    jw-r committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    a73b535 View commit details
    Browse the repository at this point in the history

  8. refactor: Restaurant에 id 프로퍼티 추가

    @jw-r
    jw-r committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    b8bf356 View commit details
    Browse the repository at this point in the history

  9. feat: 채워져있는 별을 누르면 빈 별로, 빈 별을 누르면 채워져있는 표시하는 기능 구현

    @jw-r
    jw-r committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    91795c5 View commit details
    Browse the repository at this point in the history

  10. refactor: 음식점 컴포넌트를 렌더 시, like 프로퍼티가 true라면 채워져있는 별을 표시하도록 변경

    @jw-r
    jw-r committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    c29120c View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. feat: 자주가는 음식점 탭을 클릭했을 때, 필터 컨테이너를 숨기는 기능 구현

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    88fb539 View commit details
    Browse the repository at this point in the history

  2. feat: 음식점 컴포넌트의 별을 클릭했을 때, 해당 음 

    식점의 id를 사용해 전체 음식점이 담긴 배열을 업데이트하는 기능 구현
    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    fbd3e85 View commit details
    Browse the repository at this point in the history

  3. refactor: hidden 클래스에 대해 visible이 아닌 display: none 적용

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    312742c View commit details
    Browse the repository at this point in the history

  4. fix: upper-tap 오타 upper-tab으로 수정

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    1027109 View commit details
    Browse the repository at this point in the history

  5. feat: 음식점 컴포넌트를 클릭했을 때의 처리 구현

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    0ee0df2 View commit details
    Browse the repository at this point in the history

  6. refactor: 음식점 컴포넌트에 liked 프로퍼티 제거 후, restaurant 데이터로 기능 구현

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    83ee444 View commit details
    Browse the repository at this point in the history

  7. feat: 음식점 디테일 모달에 별 삽입

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    c631cbb View commit details
    Browse the repository at this point in the history

  8. feat: 음식점 id를 사용해 음식점을 제거하는 로직 구현

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    a0f3d51 View commit details
    Browse the repository at this point in the history

  9. feat: 음식점 디테일 모달에서 삭제 버튼으로 음식점을 삭제하는 기능 구현

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    348c3d0 View commit details
    Browse the repository at this point in the history

  10. feat: 음식점이 삭제되면 해당 컴포넌트의 태그를 remove하는 기능 구현

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    72727ca View commit details
    Browse the repository at this point in the history

  11. refactor: toggleModal 메서드의 네이밍을 toggleAddRestaurantModal로 변경

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    4d4e1f3 View commit details
    Browse the repository at this point in the history

  12. refactor: 음식점의 id를 li태그의 class가 아닌 id로 할당

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    6661da2 View commit details
    Browse the repository at this point in the history

  13. refactor: 음식점 item 하나하나에서 click 이벤트를 조작하지 않고 items에서 이벤트 버블링을 하도록 변경

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    6b9818a View commit details
    Browse the repository at this point in the history

  14. refactor: header 태그를 정적으로 두고 내부의 html을 정적으로 삽입하도록 변경

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    462599c View commit details
    Browse the repository at this point in the history

  15. refactor: 컴포넌트 안의 메서드를 App파일에 구현

    @jw-r
    jw-r committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    0cc49b9 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. refactor: imgFileName을 constants 폴더로 분리

    @jw-r
    jw-r committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    ce500b1 View commit details
    Browse the repository at this point in the history

  2. test: E2E 테스트 set up

    @jw-r
    jw-r committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1d71653 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. refactor(onClickNavTab): navElements를 가져올 때, 선택자가 아닌 클래스 선택자를 사용해서 가져… 

    …오도록 변경

DOM 구조가 변경됐을 때, 해당 코드도 변경이 필요하기 변경이 적은 클래스 선택자를 사용
    @jw-r
    jw-r committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    8d633ca View commit details
    Browse the repository at this point in the history

  2. refactor(store): 범용성을 높이기 위해, key와 item을 외부에서 주입받도록 변경

    @jw-r
    jw-r committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d8566b9 View commit details
    Browse the repository at this point in the history

  3. refactor(App): filter-container의 활성화, 비활성화를 setState 메서드에서 수행하도록 변경

    @jw-r
    jw-r committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    9d33d40 View commit details
    Browse the repository at this point in the history

  4. refactor(App): setState가 실행되면 변경된 state 의 속성에 따라 로직을 수행하도록 변경 

    인자로 받은 obj를 key값 배열로 변환하여 첫번째 값을 이용해주기 보다, this.state.navTab === '자주 가는 음식점' 과 같이 신뢰할을 사용하도록 수정
    @jw-r
    jw-r committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    40a6e7c View commit details
    Browse the repository at this point in the history

  5. refactor(App): 즐겨찾기 버튼을 눌렀을 때, 채워진 별을 표시하거나 숨기는 기능을 메서드로 분리

    @jw-r
    jw-r committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2439ace View commit details
    Browse the repository at this point in the history

  6. refactor(App): dom.closest를 사용할 때, 선택자가 아닌 클래스 선택자를 사용하도록 변경

    @jw-r
    jw-r committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2bc8f56 View commit details
    Browse the repository at this point in the history

  7. refactor(dom): 매개변수의 이름을 element에서 queryString으로 변경

    @jw-r
    jw-r committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    02cc1ae View commit details
    Browse the repository at this point in the history

  8. refactor(RestaurantFilterContainer): App의 하위 클래스에 직접적으로 setState를 수정할… 

    … 권한을 줘서 이벤트 콜백 함수를 구현하지 않고, App으로부터 이벤트에 대한 콜백 함수를 넘겨받도록 변경
    @jw-r
    jw-r committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    fc7a43d View commit details
    Browse the repository at this point in the history