[1단계 - 자동차 경주 구현] 인치(한창희) 미션 제출합니다. #20
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "name": "Using fixtures to represent data", | ||
| "email": "hello@cypress.io", | ||
| "body": "Fixtures are a great way to mock data for responses to routes" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| describe("ui-play", () => { | ||
| before(() => { | ||
| cy.visit("http://localhost:5500/"); | ||
| }); | ||
|
|
||
| it("자동차 섹션을 입력하고 버튼을 클릭하면 횟수 영역이 보여진다", () => { | ||
| cy.get("#car-input").type("a,b,c,d"); | ||
| cy.get("#car-btn").click(); | ||
| cy.get("#count").should("have.css", "display", "block"); | ||
| }); | ||
|
|
||
| it("시도 횟수를 입력하고 버튼을 클릭하면 진행 영역이 보여진다", () => { | ||
| cy.get("#count-input").type(5); | ||
| cy.get("#count-btn").click(); | ||
| cy.get("#process").should("have.css", "display", "block"); | ||
| }); | ||
|
|
||
| it("자동차 이름을 입력한 순서대로 자동차들을 생성한다", () => { | ||
| const cars = ["a", "b", "c", "d"]; | ||
| cy.get(".car-player").each((v, i, arr) => { | ||
| cy.get(v).should("have.text", cars[i]); | ||
| }); | ||
| }); | ||
|
|
||
| it("시도 횟수보다 화살표의 개수가 적거나 같아야한다", () => { | ||
| cy.get(".process-car").each(v => { | ||
| if (v.find(".forward-icon").length > 0) { | ||
| cy.get(v).find(".forward-icon").its("length").should("be.lte", 5); | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| it("가장많은 화살표를 가지고 있는 차의 이름이 우승자에 있어야 한다", () => { | ||
| let largestCount = 0; | ||
| cy.get(".process-car") | ||
| .each(v => { | ||
| if (v.find(".forward-icon").length > largestCount) { | ||
| largestCount = v.find(".forward-icon").length; | ||
| } | ||
| }) | ||
| .then(() => { | ||
| cy.get(".process-car").each(v => { | ||
| if (v.find(".forward-icon").length === largestCount) { | ||
| const winner = v.find(".car-player")[0].outerText; | ||
| cy.get("#result-winner").contains(winner); | ||
| } | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| it("다시 시작하기 버튼을 클릭하면 자동차 섹션만 보이고, 입력 값이 초기화된다", () => { | ||
| cy.get("#reset-btn").click(); | ||
| cy.get("#count").should("have.css", "display", "none"); | ||
| cy.get("#process").should("have.css", "display", "none"); | ||
| cy.get("#result").should("have.css", "display", "none"); | ||
| cy.get("#process").children().should("not.exist"); | ||
| cy.get("#car-input").should("have.value", ""); | ||
| }); | ||
| }); | ||
|
|
||
| describe("ui-input-vaild-check", () => { | ||
|
There was a problem hiding this comment. 입력 테스트 (비즈니스), 레이아웃 테스트를 나눈 것은 아주 센스있는 코딩인 것 같습니다 😄 👍 👍 |
||
| beforeEach(() => { | ||
| cy.visit("http://localhost:5500/"); | ||
| cy.window() | ||
| .then(win => cy.stub(win, "alert")) | ||
| .as("alertStub"); | ||
| }); | ||
|
|
||
| it("자동차 이름이 5글자 초과하면 alert 출력", () => { | ||
| cy.get("#car-input").type("overFive,a,b,c,d"); | ||
| cy.get("#car-btn").click(); | ||
| cy.get("@alertStub").should( | ||
| "be.calledWith", | ||
| "자동차 이름의 길이는 최대 5글자 입니다." | ||
| ); | ||
| }); | ||
|
|
||
| it("자동차 이름에 공백 있으면 alert 출력", () => { | ||
| cy.get("#car-input").type("a,b,,c,d"); | ||
| cy.get("#car-btn").click(); | ||
| cy.get("@alertStub").should( | ||
| "be.calledWith", | ||
| "자동차 이름은 공백이 될 수 없습니다." | ||
| ); | ||
| }); | ||
|
|
||
| it("자동차 이름에 중복 있으면 alert 출력", () => { | ||
| cy.get("#car-input").type("a,b,a,c,d"); | ||
| cy.get("#car-btn").click(); | ||
| cy.get("@alertStub").should( | ||
| "be.calledWith", | ||
| "자동차 이름은 중복이 될 수 없습니다." | ||
| ); | ||
| }); | ||
|
|
||
| it("입력한 시도 횟수가 공백이면 alert 출력", () => { | ||
| cy.get("#car-input").type("a,b,c,d"); | ||
| cy.get("#car-btn").click(); | ||
| cy.get("#count").should("have.css", "display", "block"); | ||
| cy.get("#count-btn").click(); | ||
| cy.get("@alertStub").should( | ||
| "be.calledWith", | ||
| "시도 횟수는 공백 혹은 문자가 될 수 없습니다." | ||
| ); | ||
| }); | ||
|
|
||
| it("입력한 시도 횟수가 0 이하면 alert 출력", () => { | ||
| cy.get("#car-input").type("a,b,c,d"); | ||
| cy.get("#car-btn").click(); | ||
| cy.get("#count").should("have.css", "display", "block"); | ||
| cy.get("#count-input").type(-1); | ||
| cy.get("#count-btn").click(); | ||
| cy.get("@alertStub").should( | ||
| "be.calledWith", | ||
| "시도 횟수는 0보다 작거나 같을 수 없습니다." | ||
| ); | ||
| }); | ||
|
|
||
| it("입력한 시도 횟수가 소수면 alert 출력", () => { | ||
| cy.get("#car-input").type("a,b,c,d"); | ||
| cy.get("#car-btn").click(); | ||
| cy.get("#count").should("have.css", "display", "block"); | ||
| cy.get("#count-input").type(4.21); | ||
| cy.get("#count-btn").click(); | ||
| cy.get("@alertStub").should( | ||
|
There was a problem hiding this comment. Input -> btn -> should 와 같은 패턴이 많이 보이네요~ 이런 것도 함수로 제공하면 좋을 것 같습니다 :) |
||
| "be.calledWith", | ||
| "시도 횟수는 소수가 될 수 없습니다." | ||
| ); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /// <reference types="cypress" /> | ||
| // *********************************************************** | ||
| // This example plugins/index.js can be used to load plugins | ||
| // | ||
| // You can change the location of this file or turn off loading | ||
| // the plugins file with the 'pluginsFile' configuration option. | ||
| // | ||
| // You can read more here: | ||
| // https://on.cypress.io/plugins-guide | ||
| // *********************************************************** | ||
|
|
||
| // This function is called when a project is opened or re-opened (e.g. due to | ||
| // the project's config changing) | ||
|
|
||
| /** | ||
| * @type {Cypress.PluginConfig} | ||
| */ | ||
| module.exports = (on, config) => { | ||
| // `on` is used to hook into various events Cypress emits | ||
| // `config` is the resolved Cypress config | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // *********************************************** | ||
| // This example commands.js shows you how to | ||
| // create various custom commands and overwrite | ||
| // existing commands. | ||
| // | ||
| // For more comprehensive examples of custom | ||
| // commands please read more here: | ||
| // https://on.cypress.io/custom-commands | ||
| // *********************************************** | ||
| // | ||
| // | ||
| // -- This is a parent command -- | ||
| // Cypress.Commands.add("login", (email, password) => { ... }) | ||
| // | ||
| // | ||
| // -- This is a child command -- | ||
| // Cypress.Commands.add("drag", { prevSubject: 'element'}, (subject, options) => { ... }) | ||
| // | ||
| // | ||
| // -- This is a dual command -- | ||
| // Cypress.Commands.add("dismiss", { prevSubject: 'optional'}, (subject, options) => { ... }) | ||
| // | ||
| // | ||
| // -- This will overwrite an existing command -- | ||
| // Cypress.Commands.overwrite("visit", (originalFn, url, options) => { ... }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // *********************************************************** | ||
| // This example support/index.js is processed and | ||
| // loaded automatically before your test files. | ||
| // | ||
| // This is a great place to put global configuration and | ||
| // behavior that modifies Cypress. | ||
| // | ||
| // You can change the location of this file or turn off | ||
| // automatically serving support files with the | ||
| // 'supportFile' configuration option. | ||
| // | ||
| // You can read more here: | ||
| // https://on.cypress.io/configuration | ||
| // *********************************************************** | ||
|
|
||
| // Import commands.js using ES2015 syntax: | ||
| import './commands' | ||
|
|
||
| // Alternatively you can use CommonJS syntax: | ||
| // require('./commands') |
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "dependencies": { | ||
|
There was a problem hiding this comment. cypress는 빌드에 연관있는 툴은 아니므로, --dev 옵션을 주어 devDependencies로 이관하는게 좋지 않을까요? |
||
| "cypress": "^6.4.0" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| export const RANDOM = { | ||
|
|
||
| MAX_NUM: 9, | ||
| MIN_NUM: 0, | ||
| }; | ||
|
|
||
| export const INIT = { | ||
|
|
||
| CARS: [], | ||
| FORWARD: 0, | ||
| COUNT: 0, | ||
| }; | ||
|
There was a problem hiding this comment. 클래스에 대한 init을 상수로 관리하는 건 상황에 따라 다르겠지만, |
||
|
|
||
| export const GAME = { | ||
| FORWARD_STANDARD_NUM: 4, | ||
| GO_NUM: 1, | ||
| STOP_NUM: 0, | ||
| }; | ||
|
|
||
| export const VALID = { | ||
| CARNAME_MAX_LENGTH: 5, | ||
| CARNAME_MIN_LENGTH: 1, | ||
| COUNT_MIN_NUM: 1, | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| export const ERROR_MESSAGE = { | ||
|
|
||
| OVER_CARNAME_MAX_LENGTH: "자동차 이름의 길이는 최대 5글자 입니다.", | ||
| BLANK_CARNAME: "자동차 이름은 공백이 될 수 없습니다.", | ||
| DUPLICATE_CARNAME: "자동차 이름은 중복이 될 수 없습니다.", | ||
|
|
||
| ZERO_OR_MINUS_COUNT: "시도 횟수는 0보다 작거나 같을 수 없습니다.", | ||
| ISNAN_COUNT: "시도 횟수는 공백 혹은 문자가 될 수 없습니다.", | ||
| FLOAT_COUNT: "시도 횟수는 소수가 될 수 없습니다.", | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#***-input을 입력하고#***-btn을 클릭하는 동작이 중복되는 것 같습니다 😄해당 일련된 동작을 제공하는 함수를 만들어보는 건 어떨까요?