[럿고] 체스- 스프링 실습 1단계 제출합니다. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddaaac
reviewed
Apr 22, 2020
| @@ -0,0 +1,49 @@ | |||
| function move(moveInfo) { | |||
| $.ajax({ | |||
There was a problem hiding this comment.
단순히 ajax 요청을 위해서 jquery를 사용하기에는 너무 무겁다고 생각합니다. 내장된 XMLHttpRequest나 fetch를 공부해 보시면 좋을 것 같아요!
There was a problem hiding this comment.
여러가지에 대한 비동기 방식에 대해서 공부하는 시간이었습니다!
감사합니다!
| dataType: 'json', | ||
| contentType: 'application/json; charset=utf-8', | ||
| success: renderPiece, | ||
| error: alertMessage |
There was a problem hiding this comment.
ajax를 제거함으로써, 이 부분은 진행하지 않았습니다!
Comment on lines
+19
to
+23
| const sourceNode = document.getElementById(fromTo[0]); | ||
| const targetNode = document.getElementById(fromTo[1]); | ||
|
|
||
| targetNode.innerText = sourceNode.innerText; | ||
| sourceNode.innerText = " "; |
| getMoveInfo(); | ||
| } | ||
|
|
||
| init(); |
There was a problem hiding this comment.
getMoveInfo()와 init()이 필요할까요? window 객체의 onload를 공부해보시면 좋을 것 같네요 :)
| } | ||
| } | ||
|
|
||
| public List<Piece> findAll(String gameId) { |
There was a problem hiding this comment.
findAllPieces와 같은 네이밍을 사용하면 더 명확하게 하는 일을 파악할 수 있을 것 같습니다.
| pstmt.setString(1, gameId); | ||
| pstmt.setString(2, position.getName()); | ||
| ResultSet rs = pstmt.executeQuery(); | ||
| rs.next(); |
| PreparedStatement pstmt = con.prepareStatement(query)) { | ||
| pstmt.setString(1, gameId); | ||
| ResultSet rs = pstmt.executeQuery(); | ||
| rs.next(); |
| .orElseThrow(() -> new IllegalArgumentException("존재 하지 않는 기물 입니다.")); | ||
| } | ||
|
|
||
| public Piece create(Position position) { |
There was a problem hiding this comment.
사용할 때 PieceFactory.of(symbol).create(position)으로만 사용하는데 of() 와 create() 메서드를 합치는 건 어떨까요?
| this.position = position; | ||
| } | ||
|
|
||
| public Column plus() { |
ddaaac
approved these changes
Apr 22, 2020
ddaaac
reviewed
Apr 22, 2020
| } | ||
|
|
||
| public Map<String, String> getBoard(String gameId) { | ||
| return boardDAO.findAll(gameId) |
There was a problem hiding this comment.
리턴값을 Map<String, List <PieceDto>>로 바꾸면 어떨까요?
class PieceDto {
private String name;
private String symbol;
...
public static List<PieceDto> listFrom(List<Piece>) {
...
}
}
ddaaac
approved these changes
Apr 22, 2020
| <div id="e1" class="box">{{e1}}</div> | ||
| <div id="f1" class="box">{{f1}}</div> | ||
| <div id="g1" class="box">{{g1}}</div> | ||
| <div id="h1" class="box">{{h1}}</div> |
There was a problem hiding this comment.
위와 같이 넘겨주면 이 코드도
<#pieces>
<div id={{name}}> {{symbol}}</div>
</pieces>
와 같이 간단해지겠네요!
gracefulBrown
approved these changes
Apr 23, 2020
ksy90101
added a commit
to ksy90101/jwp-chess
that referenced
this pull request
Apr 30, 2020
* Initial Commit * refactor: DAO try - resource 적용 * refactor: BoardDAO.addPieces(), hasNotGameIn() 추가 * refactor: 방어적 복사 적용 * refactor: Name -> Symbol 변경, BoardFactory -> PiecesFactory 변경 * refactor: 세션 만료시간 추가 Co-authored-by: kouz <lastpuzly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
잘 부탁드리겠습니다! 😀