[톰캣 구현하기 - 3, 4단계] 성하(김성훈) 미션 제출합니다. #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingpyo
approved these changes
Sep 9, 2023
Comment on lines
+19
to
+26
| private static final int DEFAULT_MAX_THREAD_SIZE = 250; | ||
|
|
||
| private final ServerSocket serverSocket; | ||
| private final ExecutorService executorService; | ||
| private boolean stopped; | ||
|
|
||
| public Connector() { | ||
| this(DEFAULT_PORT, DEFAULT_ACCEPT_COUNT); | ||
| this(DEFAULT_PORT, DEFAULT_ACCEPT_COUNT, DEFAULT_MAX_THREAD_SIZE); |
| public HttpResponse service(final HttpRequest request) throws Exception { | ||
| if (request.getHttpMethod() == HttpMethod.GET) { | ||
| return doGet(request); | ||
| } else if (request.getHttpMethod() == HttpMethod.POST) { |
Comment on lines
33
to
37
| for (String uri : requestMapingMap.keySet()) { | ||
| if (uri.equals(mappingUri)) { | ||
| return requestMapingMap.get(uri); | ||
| } | ||
| } |
|
Kudos, SonarCloud Quality Gate passed!
|
ingpyo
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요~ 비버! 성하입니다! 😃
이번 3, 4단계에서는 컨트롤러 구현, 동시성 확장 기능을 구현했습니다!
HttpRequest, HttpResponse는 2단계에서 구현을 했었어서 거의 기존 구조 그대로 가져갔습니다!
컨트롤러는 요구사항 및 힌트대로 RequestMapping, Controller 인터페이스를 상속한 AbstaractController를
각각 컨트롤러가 상속받아서 구현했습니다.
Get, Post 요청 이외의 요청 시에는 예외가 발생하게 했고,
Get, Post 요청 처리 로직은 추상 메소드로 각 컨트롤러에서 구현하여 처리하도록 구현했습니다!
1,2 단계 때는 Http Request 요청이 들어 왔을 때 handle을 제대로 해주는지 판단하는 테스트가 없었어서
이번에 컨트롤러를 만들면서 빡세게 ControllerTest를 진행해봤습니다!!
리뷰 잘 부탁드립니다!! 🙇🏻♂️