[JDBC 라이브러리 구현하기 - 3단계] 다즐(최우창) 미션 제출합니다. #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HubCreator
approved these changes
Oct 8, 2023
Comment on lines
+30
to
+36
| transactionTemplate.execute(() -> { | ||
| var user = findById(id); | ||
| user.changePassword(newPassword); | ||
| userDao.update(user); | ||
| userHistoryDao.log(new UserHistory(user, createBy)); | ||
| return null; | ||
| }); |
There was a problem hiding this comment.
트랜잭션 템플릿으로 구현하니까 확실히 트랜잭션 시작과 종료를 핸들링하는 코드가 없어져, 서비스 레이어가 깔끔하네요!ㅎㅎㅎ
Comment on lines
+9
to
+10
| private static final ThreadLocal<Connection> connectionHolder = new ThreadLocal<>(); | ||
|
|
There was a problem hiding this comment.
아하 쓰레드 로컬을 사용하면 해당 스레드가 어디에서든 동일한 커넥션을 가져와서 사용할 수 있겠네요ㅎㅎㅎ 쿠우우울
HubCreator
reviewed
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 헙크 ㅎㅎ
프로젝트 일정을 처리하다 보니 미션을 주말에서야 진행하게 되었네요 🥲
3단계 미션은
TransactionTemplate을 구현해 보았습니다!구현 세부 사항은 아래와 같아요 :)
TransactionManager에서ThreadLocal을 통해 같은Connection을 공유할 수 있도록 하였습니다.TranactionCallBack을 통해 하나의 트랜잭션에서 동작해야 하는 행위를 콜백으로 전달하였습니다.#375
2단계 미션에서 남겨주신 커멘트에 대한 답변도 달아두었습니다 !
3단계 미션도 잘 부탁드립니다 🙇🏻♂️