[토닉] 1단계: 엔티티 매핑 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokhongkim
approved these changes
Jul 11, 2022
| private Long writerId; | ||
|
|
||
| @Column(nullable = false) | ||
| private LocalDateTime createdAt; |
There was a problem hiding this comment.
여러 엔티티에 동일하게 추가되는 필드가 있는데, MappedSuperclass 또는 Embeddable 을 학습해보시면 중복 코드 제거가 가능하겠네요.
둘 중 무엇을 사용하면 좋을지, 각각 어떤 장단점이 있는지 고민해서 적용해보시면 좋겠습니다.
| private Long questionId; | ||
| private LocalDateTime updatedAt; |
There was a problem hiding this comment.
생성, 수정 시각을 자동으로 관리하기 위해 Auditing 기능을 학습해서 적용해보시면 좋겠습니다.
| public class User { | ||
| public static final GuestUser GUEST_USER = new GuestUser(); | ||
|
|
||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; |
There was a problem hiding this comment.
아래 제약 조건 추가를 위해서는 어떤 설정을 해줄 수 있을까요?
alter table user
add constraint UK_a3imlf41l37utmxiquukk8ajc unique (user_id)| Answer expected = new Answer(LocalDateTime.now(), false, 1L, LocalDateTime.now(), | ||
| 1L, "contents"); | ||
| Answer actual = answerRepository.save(expected); | ||
| assertThat(actual).isEqualTo(expected); |
There was a problem hiding this comment.
actual 과 expected 가 동일하다는 테스트로 1. 테이블에 저장되었다는 것, 2. id 로 조회가 가능하다는 것에 대한 검증이 될 수 있을까요?
| import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest; | ||
|
|
||
| @DataJpaTest | ||
| public class AnswerRepositoryTest { |
There was a problem hiding this comment.
AnswerRepository, QuestionRepository, DeleteHistoryRepository 에 있는 여러 메소드에 대해 학습 테스트를 조금 더 작성해보시면 학습하는데 도움이 될 것 같아요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구 사항