[1단계 - 지하철 정보 관리 기능] 제이(이재윤) 미션 제출합니다. #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Co-authored-by: kokodak <kokodakadokok@gmail.com>
Laterality
requested changes
May 14, 2023
| import static org.mockito.Mockito.when; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| public class StationServiceMockTest { |
There was a problem hiding this comment.
단위테스트라면 다른 단위 테스트들처럼 XXXTest 형태로 네이밍하면 어떨까요?
Laterality
approved these changes
May 14, 2023
| import static org.mockito.Mockito.when; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| public class StationServiceMockTest { |
Comment on lines
+45
to
+54
| while (!queue.isEmpty()) { | ||
| Station station = queue.poll(); | ||
| stations.add(station); | ||
| visited.put(station, true); | ||
| for (Station nextStation : lineMap.get(station)) { | ||
| if (!visited.get(nextStation)) { | ||
| queue.add(nextStation); | ||
| } | ||
| } | ||
| } |
| } | ||
|
|
||
| @Override | ||
| public boolean equals(final Object o) { |
There was a problem hiding this comment.
현재 Section은 name으로 구분하고 있기 때문에(db에서도 name속성은 unique로 중복이 될 수 없습니다!) id 필드는 고려하지 않아도 될 것 같습니다!
| } | ||
|
|
||
| @Transactional | ||
| public Long saveLine(final LineCreateRequest request) { |
There was a problem hiding this comment.
LineRepository.insertLine의 반환 타입은 long인데 이 메서드는 Long 타입을 반환하네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
에단 안녕하세요? 리뷰이 제이입니다~
이번 미션은 굉장히 복잡했던 것 같습니다.
페어와 함께 Entity, Domain에 대해서 고민을 많이 했습니다.
그리고 복잡한만큼 Domain을 통해서 비즈니스 로직을 수행하고 Entity에 값을 복사해서 DB에 저장하는 식으로 미션을 진행했습니다.
이런 과정에서 Service가 굉장히 복잡해졌습니다.
Service에서 도메인을 통해 비즈니스 로직을 수행시키기도 하고,
Entity -> Domain / Domain -> Entity의 역할도 해서 이런 문제가 발생했던 것 같습니다.그래서 복잡도를 줄이기 위해 Service <-> DAO 사이에
Repository를 두어서 Entity와 Domain의 매핑의 역할을 위임해주었습니다.이에 대해 에단은 어떻게 생각하시나요?
또한 미션 제출 시간이 부족해서 당장은 E2E 테스트만 진행했습니다.
추가적인 테스트들은 리뷰를 받으면서 작성하도록 하겠습니다!
감사합니다 :)