fix(kitsu-core): Deserialize and link nested relations #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgebeily
changed the title
Empty object is passed down from root linkRelationships
|
I removed the default value that was resulting in an untested branch that was unreachable and used I think we can leave it outputting a circular JSON structure without issues though. |
…nternally JSDoc doesn't have anything for this type of thing it seems.
wopian
approved these changes
Oct 19, 2021
|
Code Climate has analyzed commit 713cafd and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
|
Released in 10.0.0-alpha.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some infinite recursion during my usage of kitsu-core. Nested relations don't properly deserialize. I fixed it by "caching" previously nested relations in a json object that's kicked around between the methods that need it.
I'd appreciate a review. One of the things I did that I'm not 100% on is having the deepest level object point to whatever the relation was, which causes a circular JSON structure. I can also make that object a leaf node and just early return, which would allow stringification of the resulting object, but it would make different "versions" of the object not contain relationships.
Let me know if this makes sense. Thanks in advance and keep up the great work on an awesome library.