fix(kitsu-core): fix deserialisation of relationships from primary data #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedep
force-pushed
the
deserialize-relationships-from-data
branch
2 times, most recently
from
890c0c4
to
a6e0c49
Compare
pedep
commented
Jun 23, 2022
pedep
force-pushed
the
deserialize-relationships-from-data
branch
from
a6e0c49
to
c83a5ec
Compare
pedep
force-pushed
the
deserialize-relationships-from-data
branch
from
c83a5ec
to
9a480b9
Compare
|
Code Climate has analyzed commit 9a480b9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
wopian
approved these changes
Jun 23, 2022
|
Thank you for the fix! 🎉 |
|
Published as |
pedep
added a commit
to pedep/ngx-kitsu
that referenced
this pull request
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue where resource relationships would not deserialise correctly, due to being removed from
includes.According to the git history of AMS, this is inteded behaviour rails-api/active_model_serializers@f4bb4c8
It seems to be described by this line in the jsonapi spec:
A compound document MUST NOT include more than one resource object for each type and id pair.(more on the topic https://discuss.jsonapi.org/t/why-is-included-an-array/76/4)
With this very minor change, this edge-case should be handled correctly.