Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kitsu-core) deserialise nested relationships of same name #693

Conversation

pedep
Copy link
Contributor

@pedep pedep commented Jul 13, 2022

Fixes #579

@codeclimate
Copy link

codeclimate bot commented Jul 13, 2022

Code Climate has analyzed commit a3100fe and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@wopian wopian added this to the 10 milestone Jul 13, 2022
@wopian wopian merged commit b47ec06 into wopian:master Jul 13, 2022
@wopian
Copy link
Owner

wopian commented Jul 13, 2022

Thank you for fixing this long-outstanding bug! ❤️

Released as 10.0.0-alpha.25

@pedep pedep deleted the fix(kitsu-core)/deserialize-same-nested-relationship branch July 14, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested same relationships does not deserialize as expected
2 participants