Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename scan command to malware-scan #75

Closed
akenion opened this issue Oct 19, 2023 · 1 comment
Closed

Rename scan command to malware-scan #75

akenion opened this issue Oct 19, 2023 · 1 comment
Assignees
Labels
dev-complete Development work to resolve this issue is complete enhancement New feature or request qa-passed QA has tested and confirmed the fix for this issue subcommand:malware-scan Related to the malware-scan subcommand subcommand:scan Related to the scan subcommand
Milestone

Comments

@akenion
Copy link
Contributor

akenion commented Oct 19, 2023

With the addition of the vuln-scan command in #64, it is no longer apparent that the existing scan command solely scans for malware and not vulnerabilities. It should be renamed to malware-scan to avoid any ambiguity.

Additionally, if scan is invoked after this change, it should inform the user that the scan command has been renamed.

@akenion akenion added the enhancement New feature or request label Oct 19, 2023
@akenion akenion added this to the voodoo-child milestone Oct 19, 2023
@akenion akenion self-assigned this Oct 19, 2023
@akenion akenion added subcommand:scan Related to the scan subcommand subcommand:malware-scan Related to the malware-scan subcommand labels Oct 23, 2023
@akenion akenion added the dev-complete Development work to resolve this issue is complete label Oct 24, 2023
@ewodrich ewodrich self-assigned this Oct 25, 2023
@ewodrich
Copy link

Verified the message "The "scan" subcommand has been renamed to "malware-scan" " is returned when the command wordfence scan is invoked. Repeat tested somewhat at random with a variety of available malware-scan options. General testing of the malware-scan command is in progress to verify the options with the new command name are continuing to work as expected.

One issue was found with the option wordfence scan --help or -h where it returned the following, however this is to be addressed in Case #85 .

usage: scan [-h]
options:
  -h, --help  show this help message and exit

@ewodrich ewodrich added the qa-passed QA has tested and confirmed the fix for this issue label Oct 26, 2023
@akenion akenion closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-complete Development work to resolve this issue is complete enhancement New feature or request qa-passed QA has tested and confirmed the fix for this issue subcommand:malware-scan Related to the malware-scan subcommand subcommand:scan Related to the scan subcommand
Projects
None yet
Development

No branches or pull requests

2 participants