Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken packaging (IMHO) #11

Closed
gthomas opened this issue May 7, 2012 · 5 comments
Closed

Broken packaging (IMHO) #11

gthomas opened this issue May 7, 2012 · 5 comments
Assignees

Comments

@gthomas
Copy link

gthomas commented May 7, 2012

This is crazy!

Put the full path to the directory containing the wordnik directory here

sys.path.append('/parent/path')

Isn't there a way to package your API such that this is not required?

@mrjf
Copy link
Contributor

mrjf commented May 7, 2012

You're totally right of course, there certainly is a better way to do that. We will soon be releasing a version that has proper packaging.

The reason the current library has some little oddities is due to how it is generated. We created it using our Swagger code generation library, which generates clients automatically based on a set of templates for a given language, and a resource declaration from the API server. Swagger is utterly fantastic, but earlier versions were oriented more towards Java-like languages, and so the Python templates weren't able to create the structures that would be more normal for a Python package.

The good news is that Swagger has subsequently gained lots of flexibility, and we will be redoing the Python templates soon. You'll be able to simply import the library as usual.

Thanks for checking out the client and for getting in touch. Always let us know if you have any questions or comments.

@ghost ghost assigned mrjf May 7, 2012
@gthomas
Copy link
Author

gthomas commented May 7, 2012

I see. I removed wordnik/api/VersionChecker.py from my fork and it works like a charm. This is probably because VersionChecker.py is a PHP file.

Thanks for the quick response!

@mrjf
Copy link
Contributor

mrjf commented May 8, 2012

Ugh, thanks, we'll fix that too.

@gthomas
Copy link
Author

gthomas commented May 8, 2012

I opened a pull request on swagger-codegen that ought to fix this issue.

@mrjf
Copy link
Contributor

mrjf commented May 8, 2012

Thanks Grant, will pull soon, and make sure this gets incorporated into new templates. Much obliged!

On May 8, 2012, at 3:21 PM, "Grant Thomas" reply@reply.github.com wrote:

I opened a pull request on swagger-codegen that ought to fix this issue.


Reply to this email directly or view it on GitHub:
#11 (comment)

@mrjf mrjf closed this as completed Aug 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants