Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WooCommerce compatibility #145

Closed
nathanaelphilip opened this issue Jul 22, 2016 · 14 comments
Closed

WooCommerce compatibility #145

nathanaelphilip opened this issue Jul 22, 2016 · 14 comments

Comments

@nathanaelphilip
Copy link

nathanaelphilip commented Jul 22, 2016

when running the WooCommerce setup script, it throws an error.
seems to have something to do with plate/src/tabs.php on line 20.

commenting it out let me run the setup, but may be worth looking into.

Using WP 4.5.3 & WooCommerce 2.6.3

edit: also running multi site

@vinkla
Copy link
Owner

vinkla commented Jul 22, 2016

@nathanaelphilip actually never tried WordPlate with WooCommerce before so it is great that you're testing it out! Could you share the error message with us?

@nathanaelphilip
Copy link
Author

i didn’t think to grab it. once it “fixed” the issue, i went through the process. it should be pretty easy to replicate, but I’ll let you know if I find anything else.

@vinkla
Copy link
Owner

vinkla commented Jul 22, 2016

Okay, good. Let me know if you find anything.

This is the line you're referring: wordplate/plate/src/tabs.php#L20

@nathanaelphilip
Copy link
Author

that is correct

@vinkla
Copy link
Owner

vinkla commented Jul 24, 2016

Closing this until we find the error message. Thanks for reporting!

@vinkla vinkla closed this as completed Jul 24, 2016
@nathanaelphilip
Copy link
Author

this is the error:

Fatal error: Uncaught Error: Call to a member function remove_help_tabs() on null in /srv/users/serverpilot/apps/quarter-ink/public/plugins/plate/src/tabs.php:20 Stack trace: #0 /srv/users/serverpilot/apps/quarter-ink/public/wordpress/wp-includes/plugin.php(525): {closure}('') #1 /srv/users/serverpilot/apps/quarter-ink/public/plugins/woocommerce/includes/admin/class-wc-admin-setup-wizard.php(150): do_action('admin_head') #2 /srv/users/serverpilot/apps/quarter-ink/public/plugins/woocommerce/includes/admin/class-wc-admin-setup-wizard.php(125): WC_Admin_Setup_Wizard->setup_wizard_header() #3 /srv/users/serverpilot/apps/quarter-ink/public/wordpress/wp-includes/plugin.php(525): WC_Admin_Setup_Wizard->setup_wizard('') #4 /srv/users/serverpilot/apps/quarter-ink/public/wordpress/wp-admin/admin.php(168): do_action('admin_init') #5 {main} thrown in /srv/users/serverpilot/apps/quarter-ink/public/plugins/plate/src/tabs.php on line 20

@vinkla
Copy link
Owner

vinkla commented Aug 29, 2016

Are you sure Wordpress is loaded where the error is thrown?

@nathanaelphilip
Copy link
Author

yep - you should be able to easily replicate it yourself. just install woocommerce and go through the set up process (where you install WooCommerce pages, etc)

@vinkla vinkla reopened this Aug 29, 2016
@vinkla
Copy link
Owner

vinkla commented Aug 29, 2016

Reopening this for now. Will look into this in the future.

@puredazzle
Copy link
Contributor

I think it is because we call the remove help tabs to early because WooCommerce try to add help tabs by themself and it's already cleared.

See here http://wordpress.stackexchange.com/questions/50723/how-to-remove-help-tabs

I can test it tomorrow and make a PR. Otherwise feel free to test it now and update.

@puredazzle
Copy link
Contributor

Made a PR here: wordplate/plate#1

@vinkla
Copy link
Owner

vinkla commented Aug 30, 2016

The fix is merged and version 2.1.1 was just released. @nathanaelphilip could you please try again? Remember to run composer update.

@vinkla vinkla closed this as completed Aug 30, 2016
@nathanaelphilip
Copy link
Author

we did it!

@vinkla
Copy link
Owner

vinkla commented Aug 30, 2016

@nathanaelphilip great! Let us know if there is anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants