-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WooCommerce compatibility #145
Comments
@nathanaelphilip actually never tried WordPlate with WooCommerce before so it is great that you're testing it out! Could you share the error message with us? |
i didn’t think to grab it. once it “fixed” the issue, i went through the process. it should be pretty easy to replicate, but I’ll let you know if I find anything else. |
Okay, good. Let me know if you find anything. This is the line you're referring: wordplate/plate/src/tabs.php#L20 |
that is correct |
Closing this until we find the error message. Thanks for reporting! |
this is the error:
|
Are you sure Wordpress is loaded where the error is thrown? |
yep - you should be able to easily replicate it yourself. just install woocommerce and go through the set up process (where you install WooCommerce pages, etc) |
Reopening this for now. Will look into this in the future. |
I think it is because we call the remove help tabs to early because WooCommerce try to add help tabs by themself and it's already cleared. See here http://wordpress.stackexchange.com/questions/50723/how-to-remove-help-tabs I can test it tomorrow and make a PR. Otherwise feel free to test it now and update. |
Made a PR here: wordplate/plate#1 |
The fix is merged and version 2.1.1 was just released. @nathanaelphilip could you please try again? Remember to run |
we did it! |
@nathanaelphilip great! Let us know if there is anything else. |
when running the WooCommerce setup script, it throws an error.
seems to have something to do with
plate/src/tabs.php
online 20
.commenting it out let me run the setup, but may be worth looking into.
Using WP 4.5.3 & WooCommerce 2.6.3
edit: also running multi site
The text was updated successfully, but these errors were encountered: