Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the library be fully migrated to AndroidX? #933

Closed
ygnessin opened this issue Dec 3, 2020 · 3 comments
Closed

Can the library be fully migrated to AndroidX? #933

ygnessin opened this issue Dec 3, 2020 · 3 comments

Comments

@ygnessin
Copy link

ygnessin commented Dec 3, 2020

Expected

First of all, thank you for maintaining such a wonderful library!

For any version past v1.3.28 I would expect this library to be migrated to AndroidX, and therefore not to require jetifier to be enabled.

Observed

When using the can-i-drop-jetifier gradle plugin, I receive the following result:

Cannot drop Jetifier due to following external dependencies:

* com.github.wordpress-mobile.WordPress-Aztec-Android:aztec:v1.3.45

Reproduced

  1. Have this in your gradle file:
implementation "com.github.wordpress-mobile.WordPress-Aztec-Android:aztec:v1.3.45"
  1. Set up can-i-drop-jetifier according to the readme
  2. Run ./gradlew -Pandroid.enableJetifier=false canIDropJetifier
  3. Observe the error message above

Other

I noticed in the build.gradle file a couple dependencies that may or may not be contributing to this issue:

vectorDrawables.useSupportLibrary = true
...
implementation 'androidx.legacy:legacy-support-v4:1.0.0'

Hopefully that helps. Thanks again for the wonderful library!

@ygnessin ygnessin changed the title Can the library be fully migrated to AndroidX Can the library be fully migrated to AndroidX? Dec 3, 2020
@ygnessin
Copy link
Author

ygnessin commented Dec 9, 2020

I was able to use the plugin's verbose setting to find a little more info:

* com.github.wordpress-mobile.WordPress-Aztec-Android:aztec:v1.3.45
  \-- org.wordpress:utils:1.21
   \-- com.android.support:support-v13:27.1.1
  \-- org.wordpress:utils:1.21
   \-- com.android.support:design:27.1.1
  \-- org.wordpress:utils:1.21
   \-- com.android.support:recyclerview-v7:27.1.1

Hopefully this helps you get to the bottom of it!

@ygnessin
Copy link
Author

ygnessin commented Dec 9, 2020

In the meantime, I have found a work-around for this by exposing a direct dependency to org.wordpress:utils:

implementation "com.github.wordpress-mobile.WordPress-Aztec-Android:aztec:v1.3.45"
implementation "org.wordpress:utils:1.29"

These seems to solve the problem for me for now.

@oguzkocer
Copy link
Contributor

@ygnessin Thank you for reporting this issue. We have dropped jetifier in #946. I am sorry it took so long to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants