Drop jetifier #946
Merged
Drop jetifier #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malinajirka
force-pushed
the
drop-jetifier
branch
from
1b32af5
to
fd1c3e9
Compare
malinajirka
force-pushed
the
drop-jetifier
branch
from
1d629b5
to
c4198cc
Compare
malinajirka
changed the base branch from
develop
to
remove-xamarin-testcloud
oguzkocer
approved these changes
Dec 13, 2021
This was referenced Dec 13, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure #947 is merged first -> update the target branch to
developunless GitHub does it automatically.This PR is part of the effort to drop Jetifier from WPAndroid. Aztec directly doesn't rely on the android support library, however, it is dependant on utils version which is not migrated to AndroidX. This PR is technically not necessary to unblock the PR in WPAndroid as gradle can resolve the utils version conflict and use the newer version in WPAndroid. However, since we are using composite builds and having inconsistent versions could bite us, I opted for updating it everywhere for consistency.
Changes
To test
Make sure to disable Jetifier in your local gradle.properties => Smoke test the example app
Make sure strings will be translated:
strings.xmlas a part of the integration PR.