Fix NSSecureCoding implementations

@mokagio This should fix the `testPaste{Image,Video}WithoutFormatting` test failures.
 - I have searched the code for `decodeObject(forKey` occurrences and confirmed there wasn't any left
 - But I have not triple-checked that *every* custom subclass of anything we might encode in our `NSAttributedString` attributes have had `+supportsSecureCoding` redefined

Indeed, apparently, **even if** the parent class already overrides it to return `true`, subclasses which override `init?(coder:)`/`encode(with:)` from their parent class need to also re-override `+supportsSecureCoding`. I've added the overrides in classes that I've modified, but there may be more classes that might not be covered by our unit tests around archiving/pasting but would still require it to be added? So would be worth making another pass to be sure we didn't forget any,

Aztec/Classes/EditorView/EditorView.swift

@@ -99,8 +99,8 @@ public class EditorView: UIView {
     // MARK: - Initializers
 
     public required init?(coder aDecoder: NSCoder) {
-        guard let htmlTextView = aDecoder.decodeObject(forKey: EditorView.htmlTextViewKey) as? UITextView,
-            let richTextView = aDecoder.decodeObject(forKey: EditorView.richTextViewKey) as? TextView else {
+        guard let htmlTextView = aDecoder.decodeObject(of: UITextView.self, forKey: EditorView.htmlTextViewKey),
+              let richTextView = aDecoder.decodeObject(of: TextView.self, forKey: EditorView.richTextViewKey) else {
                 return nil
         }
 

Aztec/Classes/Extensions/NSAttributedString+Archive.swift

@@ -11,7 +11,7 @@ extension NSAttributedString
     }
 
     static func unarchive(with data: Data) throws -> NSAttributedString? {
-        return try NSKeyedUnarchiver.unarchivedObject(ofClass: NSAttributedString.self, from: data)
+        return try NSKeyedUnarchiver.unarchivedObject(ofClasses: [NSAttributedString.self, HTMLRepresentation.self], from: data) as? NSAttributedString
     }
 
 }

Aztec/Classes/Libxml2/DOM/Data/Attribute.swift

@@ -3,7 +3,7 @@ import Foundation
 /// Represents a basic attribute with no value.  This is also the base class for all other
 /// attributes.
 ///
-public class Attribute: NSObject, CustomReflectable, NSCoding {
+public class Attribute: NSObject, CustomReflectable, NSSecureCoding {
 
     // MARK: - Attribute Definition Properties
 
@@ -52,15 +52,15 @@ public class Attribute: NSObject, CustomReflectable, NSCoding {
 
     public required convenience init?(coder aDecoder: NSCoder) {
         // TODO: This is a Work in Progress. Let's also get Attribute conforming to Codable!
-        guard let name = aDecoder.decodeObject(forKey: Keys.name) as? String,
-            let rawValue = aDecoder.decodeObject(forKey: Keys.value) as? Data,
-            let value = try? JSONDecoder().decode(Value.self, from: rawValue) else
+        guard let name = aDecoder.decodeObject(of: NSString.self, forKey: Keys.name),
+              let rawValue = aDecoder.decodeObject(of: NSData.self, forKey: Keys.value),
+            let value = try? JSONDecoder().decode(Value.self, from: rawValue as Data) else
         {
             assertionFailure("Review the logic.")
             return nil
         }
 
-        self.init(name: name, value: value)
+        self.init(name: name as String, value: value)
     }
 
     open func encode(with aCoder: NSCoder) {
@@ -72,6 +72,8 @@ public class Attribute: NSObject, CustomReflectable, NSCoding {
         }
     }
 
+    public class var supportsSecureCoding: Bool { true }
+
     // MARK: - Equatable
 
     public override func isEqual(_ object: Any?) -> Bool {

Aztec/Classes/NSAttributedString/Attributes/HTMLRepresentation.swift

@@ -2,7 +2,7 @@ import Foundation
 
 /// This enum specifies the different entities that can represent a style in HTML.
 ///
-public class HTMLRepresentation: NSObject, NSCoding {
+public class HTMLRepresentation: NSObject, NSSecureCoding {
     public enum Kind {
         case attribute(Attribute)
         case element(HTMLElementRepresentation)
@@ -24,18 +24,18 @@ public class HTMLRepresentation: NSObject, NSCoding {
     }
 
     public required init?(coder aDecoder: NSCoder) {
-        if let attribute = aDecoder.decodeObject(forKey: Keys.attribute) as? Attribute {
+        if let attribute = aDecoder.decodeObject(of: Attribute.self, forKey: Keys.attribute) {
             kind = .attribute(attribute)
             return
         }
 
-        if let element = aDecoder.decodeObject(forKey: Keys.element) as? HTMLElementRepresentation {
+        if let element = aDecoder.decodeObject(of: HTMLElementRepresentation.self, forKey: Keys.element) {
             kind = .element(element)
             return
         }
 
-        if let rawCSS = aDecoder.decodeObject(forKey: Keys.inline) as? String,
-            let decodedCSS = CSSAttribute(for: rawCSS) {
+        if let rawCSS = aDecoder.decodeObject(of: NSString.self, forKey: Keys.inline),
+            let decodedCSS = CSSAttribute(for: rawCSS as String) {
             kind = .inlineCss(decodedCSS)
             return
         }
@@ -53,12 +53,14 @@ public class HTMLRepresentation: NSObject, NSCoding {
             aCoder.encode(css.toString(), forKey: Keys.inline)
         }
     }
+
+    public class var supportsSecureCoding: Bool { true }
 }
 
 
 // MARK: - HTMLElementRepresentation
 //
-public class HTMLElementRepresentation: NSObject, CustomReflectable, NSCoding {
+public class HTMLElementRepresentation: NSObject, CustomReflectable, NSSecureCoding {
     @objc let name: String
     @objc let attributes: [Attribute]
 
@@ -78,20 +80,30 @@ public class HTMLElementRepresentation: NSObject, CustomReflectable, NSCoding {
     // MARK: - NSCoding
 
     public required convenience init?(coder aDecoder: NSCoder) {
-        guard let name = aDecoder.decodeObject(forKey: #keyPath(name)) as? String,
-            let attributes = aDecoder.decodeObject(forKey: #keyPath(attributes)) as? [Attribute]
-        else {
+        guard let name = aDecoder.decodeObject(of: NSString.self, forKey: #keyPath(name)) else {
+            fatalError()
+        }
+        let decodedAttributes: [Attribute]?
+
+        if #available(iOS 14.0, *) {
+            decodedAttributes = aDecoder.decodeArrayOfObjects(ofClass: Attribute.self, forKey: #keyPath(attributes))
+        } else {
+            decodedAttributes = aDecoder.decodeObject(of: NSArray.self, forKey: #keyPath(attributes)) as? [Attribute]
+        }
+        guard let attributes = decodedAttributes else {
             fatalError()
         }
 
-        self.init(name: name, attributes: attributes)
+        self.init(name: name as String, attributes: attributes)
     }
 
     open func encode(with aCoder: NSCoder) {
         aCoder.encode(name, forKey: #keyPath(name))
         aCoder.encode(attributes, forKey: #keyPath(attributes))
     }
 
+    public class var supportsSecureCoding: Bool { true }
+
     // MARK: - CustomReflectable
 
     public var customMirror: Mirror {

Aztec/Classes/NSAttributedString/Attributes/UnsupportedHTML.swift

@@ -3,7 +3,7 @@ import Foundation
 
 // MARK: - UnsupportedHTML
 //
-class UnsupportedHTML: NSObject {
+class UnsupportedHTML: NSObject, NSSecureCoding {
 
     /// ElementRepresentation for Unsupported HTML
     ///
@@ -18,12 +18,20 @@ class UnsupportedHTML: NSObject {
     /// Required Initializers
     ///
     public required init?(coder aDecoder: NSCoder) {
-        guard let representations = aDecoder.decodeObject(forKey: Keys.representations) as? [HTMLElementRepresentation] else {
-            return nil
+        let representations: [HTMLElementRepresentation]?
+        if #available(iOS 14.0, *) {
+            representations = aDecoder.decodeArrayOfObjects(ofClass: HTMLElementRepresentation.self, forKey: Keys.representations)
+        } else {
+            representations = aDecoder.decodeObject(of: NSArray.self, forKey: Keys.representations) as? [HTMLElementRepresentation]
         }
 
+        guard let representations else {
+            return nil
+        }
         self.representations = representations
     }
+
+    class var supportsSecureCoding: Bool { true }
 }
 
 

Aztec/Classes/TextKit/CommentAttachment.swift

@@ -32,11 +32,11 @@ open class CommentAttachment: NSTextAttachment, RenderableAttachment {
     public required init?(coder aDecoder: NSCoder) {
         super.init(data: nil, ofType: nil)
 
-        guard let text = aDecoder.decodeObject(forKey: Keys.text) as? String else {
+        guard let text = aDecoder.decodeObject(of: NSString.self, forKey: Keys.text) else {
             return
         }
 
-        self.text = text
+        self.text = text as String
     }
 
 
@@ -48,7 +48,7 @@ open class CommentAttachment: NSTextAttachment, RenderableAttachment {
         aCoder.encode(text, forKey: Keys.text)
     }
 
-
+    override public class var supportsSecureCoding: Bool { true }
 
     // MARK: - NSTextAttachmentContainer
 

Aztec/Classes/TextKit/HTMLAttachment.swift

@@ -40,16 +40,17 @@ open class HTMLAttachment: NSTextAttachment, RenderableAttachment  {
     public required init?(coder aDecoder: NSCoder) {
         super.init(data: nil, ofType: nil)
 
-        guard let rootTagName = aDecoder.decodeObject(forKey: Keys.rootTagName) as? String,
-            let rawHTML = aDecoder.decodeObject(forKey: Keys.rawHTML) as? String
+        guard let rootTagName = aDecoder.decodeObject(of: NSString.self, forKey: Keys.rootTagName),
+              let rawHTML = aDecoder.decodeObject(of: NSString.self, forKey: Keys.rawHTML)
             else {
                 return
         }
 
-        self.rootTagName = rootTagName
-        self.rawHTML = rawHTML
+        self.rootTagName = rootTagName as String
+        self.rawHTML = rawHTML as String
     }
 
+    override public class var supportsSecureCoding: Bool { true }
 
     /// Extracts the root tag name from a given HTML string
     ///

Aztec/Classes/TextKit/ImageAttachment.swift

@@ -74,6 +74,8 @@ open class ImageAttachment: MediaAttachment {
         aCoder.encode(size.rawValue, forKey: EncodeKeys.size.rawValue)
     }
 
+    override public class var supportsSecureCoding: Bool { true }
+
     private enum EncodeKeys: String {
         case alignment
         case size

Aztec/Classes/TextKit/MediaAttachment.swift

@@ -153,10 +153,12 @@ open class MediaAttachment: NSTextAttachment {
         ///
         super.init(coder: aDecoder)
 
-        identifier = aDecoder.decodeObject(forKey: EncodeKeys.identifier.rawValue) as? String ?? identifier
-        url = aDecoder.decodeObject(forKey: EncodeKeys.url.rawValue) as? URL
+        identifier = aDecoder.decodeObject(of: NSString.self, forKey: EncodeKeys.identifier.rawValue) as? String ?? identifier
+        url = aDecoder.decodeObject(of: NSURL.self, forKey: EncodeKeys.url.rawValue) as? URL
     }
 
+    override public class var supportsSecureCoding: Bool { true }
+
     /// Required Initializer
     ///
     override required public init(data contentData: Data?, ofType uti: String?) {

Aztec/Classes/TextKit/ParagraphProperty/Blockquote.swift

@@ -6,6 +6,8 @@ class Blockquote: ParagraphProperty {
         super.encode(with: aCoder)
     }
 
+    override public class var supportsSecureCoding: Bool { true }
+
     override public init(with representation: HTMLRepresentation? = nil) {
         super.init(with: representation)
     }

Aztec/Classes/TextKit/ParagraphProperty/Figcaption.swift

@@ -10,14 +10,16 @@ class Figcaption: ParagraphProperty {
     }
 
     required public init?(coder aDecoder: NSCoder){
-        defaultFont = aDecoder.decodeObject(forKey: CodingKeys.defaultFont) as! UIFont
+        defaultFont = aDecoder.decodeObject(of: UIFont.self, forKey: CodingKeys.defaultFont)!
         super.init(coder: aDecoder)
     }
 
     public override func encode(with aCoder: NSCoder) {
         super.encode(with: aCoder)
         aCoder.encode(defaultFont, forKey: CodingKeys.defaultFont)
     }
+
+    override public class var supportsSecureCoding: Bool { true }
 }
 
 private extension Figcaption {

Aztec/Classes/TextKit/ParagraphProperty/Figure.swift

@@ -5,7 +5,9 @@ class Figure: ParagraphProperty {
     public override func encode(with aCoder: NSCoder) {
         super.encode(with: aCoder)
     }
-
+
+    override public class var supportsSecureCoding: Bool { true }
+
     override public init(with representation: HTMLRepresentation? = nil) {
         super.init(with: representation)
     }

Aztec/Classes/TextKit/ParagraphProperty/HTMLDiv.swift

@@ -9,6 +9,8 @@ class HTMLDiv: ParagraphProperty {
         super.encode(with: aCoder)
     }
 
+    override public class var supportsSecureCoding: Bool { true }
+
     override public init(with representation: HTMLRepresentation? = nil) {
         super.init(with: representation)
     }

Aztec/Classes/TextKit/ParagraphProperty/HTMLLi.swift

@@ -6,6 +6,8 @@ class HTMLLi: ParagraphProperty {
         super.encode(with: aCoder)
     }
 
+    override public class var supportsSecureCoding: Bool { true }
+
     override public init(with representation: HTMLRepresentation? = nil) {
         super.init(with: representation)
     }

Aztec/Classes/TextKit/ParagraphProperty/HTMLParagraph.swift

@@ -9,6 +9,8 @@ class HTMLParagraph: ParagraphProperty {
         super.encode(with: aCoder)
     }
 
+    override public class var supportsSecureCoding: Bool { true }
+
     override public init(with representation: HTMLRepresentation? = nil) {
         super.init(with: representation)
     }

Aztec/Classes/TextKit/ParagraphProperty/HTMLPre.swift

@@ -6,6 +6,8 @@ class HTMLPre: ParagraphProperty {
         super.encode(with: aCoder)
     }
 
+    override public class var supportsSecureCoding: Bool { true }
+
     override public init(with representation: HTMLRepresentation? = nil) {
         super.init(with: representation)
     }

Aztec/Classes/TextKit/ParagraphProperty/Header.swift

@@ -83,6 +83,8 @@ open class Header: ParagraphProperty {
         aCoder.encode(level.rawValue, forKey: Keys.level)
     }
 
+    override public class var supportsSecureCoding: Bool { true }
+
     static func ==(lhs: Header, rhs: Header) -> Bool {
         return lhs.level == rhs.level
     }

Aztec/Classes/TextKit/ParagraphProperty/ParagraphProperty.swift

@@ -1,6 +1,6 @@
 import Foundation
 
-open class ParagraphProperty: NSObject, NSCoding {
+open class ParagraphProperty: NSObject, NSSecureCoding {
 
     open var representation: HTMLRepresentation?
 
@@ -19,6 +19,8 @@ open class ParagraphProperty: NSObject, NSCoding {
     public func encode(with aCoder: NSCoder) {
     }
 
+    public class var supportsSecureCoding: Bool { true }
+
     static func ==(lhs: ParagraphProperty, rhs: ParagraphProperty) -> Bool {
         return lhs === rhs
     }

Aztec/Classes/TextKit/ParagraphProperty/TextList.swift

@@ -84,6 +84,8 @@ open class TextList: ParagraphProperty {
         aCoder.encode(reversed, forKey: AttributeType.reversed.rawValue)
     }
 
+    override public class var supportsSecureCoding: Bool { true }
+
     public static func ==(lhs: TextList, rhs: TextList) -> Bool {
         return lhs.style == rhs.style && lhs.start == rhs.start && lhs.reversed == rhs.reversed
     }

Aztec/Classes/TextKit/ParagraphStyle.swift

@@ -89,7 +89,14 @@ open class ParagraphStyle: NSMutableParagraphStyle, CustomReflectable {
 
     public required init?(coder aDecoder: NSCoder) {
 
-        if let encodedProperties = aDecoder.decodeObject(forKey:String(describing: ParagraphProperty.self)) as? [ParagraphProperty] {
+        let encodedProperties: [ParagraphProperty]?
+        if #available(iOS 14.0, *) {
+            encodedProperties = aDecoder.decodeArrayOfObjects(ofClass: ParagraphProperty.self, forKey: String(describing: ParagraphProperty.self))
+        } else {
+            encodedProperties = aDecoder.decodeObject(of: NSArray.self, forKey: String(describing: ParagraphProperty.self)) as? [ParagraphProperty]
+        }
+
+        if let encodedProperties {
             properties = encodedProperties
         }
 
@@ -105,6 +112,8 @@ open class ParagraphStyle: NSMutableParagraphStyle, CustomReflectable {
         aCoder.encode(headerLevel, forKey: EncodingKeys.headerLevel.rawValue)
     }
 
+    override public class var supportsSecureCoding: Bool { true }
+
     override open func setParagraphStyle(_ baseParagraphStyle: NSParagraphStyle) {
 
         super.setParagraphStyle(baseParagraphStyle)

Aztec/Classes/TextKit/VideoAttachment.swift

@@ -39,10 +39,12 @@ open class VideoAttachment: MediaAttachment {
         super.init(coder: aDecoder)
 
         if aDecoder.containsValue(forKey: EncodeKeys.posterURL.rawValue) {
-            posterURL = aDecoder.decodeObject(forKey: EncodeKeys.posterURL.rawValue) as? URL
+            posterURL = aDecoder.decodeObject(of: NSURL.self, forKey: EncodeKeys.posterURL.rawValue) as? URL
         }
     }
 
+    override public class var supportsSecureCoding: Bool { true }
+
     /// Required Initializer
     ///
     required public init(identifier: String, url: URL?) {