Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose indentation operations #1353

Merged

Conversation

cbess
Copy link
Contributor

@cbess cbess commented Mar 26, 2022

This will make increase/decrease indentation actions visible to other developers, namely to provide them as format bar actions.

To test:
Perform an indentation increase or decrease action (e.g. via keyboard command) and it should function as expected.

- make increase/decrease indentation actions visible
- cleanup code
@cbess
Copy link
Contributor Author

cbess commented Jul 29, 2022

@crazytonyli Can this be merged?

Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good change. Thanks for the PR!

@cbess
Copy link
Contributor Author

cbess commented Aug 10, 2022

@diegoreymendez @crazytonyli Can this be merged?

@diegoreymendez diegoreymendez merged commit 91cf065 into wordpress-mobile:develop Aug 10, 2022
@cbess cbess deleted the expose-indentation-actions branch August 15, 2022 20:57
cbess added a commit to cbess/AztecEditor-iOS that referenced this pull request Aug 6, 2023
commit 4d0522d
Merge: 2b54f87 59d5090
Author: Gio Lodi <gio.lodi@automattic.com>
Date:   Thu Mar 9 12:08:36 2023 +1100

    Point `bash-cache` plugin to new `a8c-ci-toolkit` location (wordpress-mobile#1367)

commit 59d5090
Author: Gio Lodi <gio@mokacoding.com>
Date:   Mon Mar 6 21:10:15 2023 +1100

    Remove unused YAML anchor and fix indentation in pipeline

commit e0526bf
Author: Gio Lodi <gio@mokacoding.com>
Date:   Mon Mar 6 21:09:53 2023 +1100

    Point `bash-cache` plugin to new `a8c-ci-toolkit` location

    While I was at it, I also updated the version to the latest, 2.13.0.

    This was done via:

    ```
    find . -type f -name "*.yml" -exec sed -i '' 's/automattic\/bash-cache#[0-9.]\{1,\}/automattic\/a8c-ci-toolkit#2.13.0/g' {} +
    ```

commit 2b54f87
Merge: b7d8a70 d18d0a8
Author: Gio Lodi <giovanni.lodi42@gmail.com>
Date:   Thu Oct 20 16:59:18 2022 +1100

    Add `CHANGELOG.md` (wordpress-mobile#1365)

commit d18d0a8
Author: Gio Lodi <gio@mokacoding.com>
Date:   Thu Oct 20 15:18:16 2022 +1100

    Update `PULL_REQUEST_TEMPLATE.md` with note about `CHANGELOG.md`

commit 2c73ef5
Author: Gio Lodi <gio@mokacoding.com>
Date:   Thu Oct 20 14:32:38 2022 +1100

    Add changelog entry about changelog itself

commit 212ce2f
Author: Gio Lodi <gio@mokacoding.com>
Date:   Thu Oct 20 14:15:12 2022 +1100

    Update `CHANGELOG.md` with new format

commit b7d8a70
Merge: 91cf065 40afa55
Author: Gio Lodi <giovanni.lodi42@gmail.com>
Date:   Tue Oct 4 10:29:42 2022 +1100

    Tools upgrade: Ruby 2.7.4, bash-cache 2.8.0 (wordpress-mobile#1363)

commit 40afa55
Author: Gio Lodi <gio@mokacoding.com>
Date:   Mon Oct 3 20:00:33 2022 +1100

    Use `bash-cache` Buildkite plugin version 2.8.0

    This version includes a fix that removes the need to run
    `gem install bundler` before each step.

commit bd8840a
Author: Gio Lodi <gio@mokacoding.com>
Date:   Mon Oct 3 19:59:52 2022 +1100

    Use Ruby version 2.7.4

commit 91cf065
Merge: 9d8d9b8 1ce621c
Author: Diego Rey Mendez <diegoreymendez@users.noreply.github.com>
Date:   Wed Aug 10 15:07:41 2022 +0200

    Merge pull request wordpress-mobile#1353 from cbess/expose-indentation-actions

    Expose indentation operations

commit 9d8d9b8
Merge: b16c763 7eb60c7
Author: Tony Li <i@crazytony.li>
Date:   Mon Jul 25 11:11:13 2022 +1200

    Merge pull request wordpress-mobile#1359 from wordpress-mobile/remove/circle-ci

    Remove CircleCI

commit 7eb60c7
Author: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>
Date:   Fri Jul 22 23:23:27 2022 -0600

    Trigger Build

commit f91511e
Author: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>
Date:   Thu Jul 21 23:03:28 2022 -0600

    Remove CircleCI

commit 1ce621c
Author: C. Bess <cbess@users.noreply.github.com>
Date:   Sat Mar 26 12:31:51 2022 -0500

    cleanup whitespace

commit ed55d4a
Author: C. Bess <cbess@users.noreply.github.com>
Date:   Sat Mar 26 12:31:03 2022 -0500

    cleanup whitespace

commit 4561534
Author: C. Bess <cbess@users.noreply.github.com>
Date:   Sat Mar 26 12:01:30 2022 -0500

    expose indentation operations

    - make increase/decrease indentation actions visible
    - cleanup code
@fluiddot fluiddot added this to the 1.19.9 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants