Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Xcode 15.3 in CI #1392

Open
wants to merge 20 commits into
base: tooling/fix-sync-pod-publication
Choose a base branch
from

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    dccf8ef View commit details
    Browse the repository at this point in the history
  2. Address an access control warning

    > Non-'@objc' instance method in extensions cannot be overridden;
    > use 'public' instead
    mokagio committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    afc4064 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    168f40e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2f50d83 View commit details
    Browse the repository at this point in the history
  5. Use Xcode 15.3 in CI

    mokagio committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    380e6ac View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0b59180 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    34808d7 View commit details
    Browse the repository at this point in the history
  8. Allow warnings when validating podspec

    Ideally, this should be removed once the warnings have been addressed
    mokagio committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5baf0b9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    78bd117 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e41da8f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    04e4fc8 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge remote-tracking branch 'origin/tooling/fix-sync-pod-publication…

    …' into mokagio/xcode-15.3
    mokagio committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    210f02c View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Fix NSSecureCoding implementations

    @mokagio This should fix the `testPaste{Image,Video}WithoutFormatting` test failures.
     - I have searched the code for `decodeObject(forKey` occurrences and confirmed there wasn't any left
     - But I have not triple-checked that *every* custom subclass of anything we might encode in our `NSAttributedString` attributes have had `+supportsSecureCoding` redefined
    
    Indeed, apparently, **even if** the parent class already overrides it to return `true`, subclasses which override `init?(coder:)`/`encode(with:)` from their parent class need to also re-override `+supportsSecureCoding`. I've added the overrides in classes that I've modified, but there may be more classes that might not be covered by our unit tests around archiving/pasting but would still require it to be added? So would be worth making another pass to be sure we didn't forget any,
    AliSoftware committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    665b15b View commit details
    Browse the repository at this point in the history
  2. Use UTType.utf8PlainText (explicit encoding) instead of `kUTTypePla…

    …inText`
    
    Since newer versions of iOS use this new `public.utf8-plain-text` UTI instead of `public.plain-text` like in previous OS versions.
    AliSoftware committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    90c0e4d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5c3004b View commit details
    Browse the repository at this point in the history
  4. Revert "Fix overriding non-open class outside module"

    This reverts commit 5c3004b, because I'm not convinced that's a good idea.
    
    We should double-check that **not** having `+supportsSecureCoding` declared on this subclass doesn't make it fail to be copy/pasted (i.e. archived/unarchived)—like similar cases happened when running Aztec tests. Or if we need `+supportsSecureCoding`, we need to find a way to override/redefine it across module boundaries…
    AliSoftware committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e21dbff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c67821c View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Configuration menu
    Copy the full SHA
    83e548f View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Configuration menu
    Copy the full SHA
    ce0726e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1395 from wordpress-mobile/fix/shortcode-test

    Fix - Shortcode test
    geriux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7531747 View commit details
    Browse the repository at this point in the history