Merge pull request #11927 from wordpress-mobile/fix-fragment-lifecycl…

…e-in-bottom-nav Replace FragmentTransaction.show/hide with attach/detach - fix lifecycle
wordpress-mobile · May 15, 2020 · 0f863e7 · 0f863e7
2 parents 45e46a4 + b41f81a
commit 0f863e7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/main/WPMainNavigationView.kt b/WordPress/src/main/java/org/wordpress/android/ui/main/WPMainNavigationView.kt
@@ -166,9 +166,9 @@ class WPMainNavigationView @JvmOverloads constructor(
         val previousFragment = navAdapter.getFragment(prevPosition)
         if (fragment != null) {
             if (previousFragment != null) {
-                fragmentManager.beginTransaction().hide(previousFragment).show(fragment).commit()
+                fragmentManager.beginTransaction().detach(previousFragment).attach(fragment).commit()
             } else {
-                fragmentManager.beginTransaction().show(fragment).commit()
+                fragmentManager.beginTransaction().attach(fragment).commit()
             }
         }
         prevPosition = position