Merge pull request #12294 from wordpress-mobile/fix/remove-unused-cli…

…ck-event Remove unnecessary click event
wordpress-mobile · Jul 9, 2020 · eca8986 · eca8986
2 parents 03e4240 + 61596a7
commit eca8986
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 11 deletions.
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/accounts/UnifiedLoginTracker.kt b/WordPress/src/main/java/org/wordpress/android/ui/accounts/UnifiedLoginTracker.kt
@@ -156,15 +156,13 @@ class UnifiedLoginTracker
         LOGIN_WITH_SITE_ADDRESS("login_with_site_address"),
         LOGIN_WITH_GOOGLE("login_with_google"),
         FORGOTTEN_PASSWORD("forgotten_password"),
-        USE_PASSWORD_INSTEAD("use_password_instead"),
         TERMS_OF_SERVICE_CLICKED("terms_of_service_clicked"),
         SIGNUP_WITH_EMAIL("signup_with_email"),
         SIGNUP_WITH_GOOGLE("signup_with_google"),
         OPEN_EMAIL_CLIENT("open_email_client"),
         SHOW_HELP("show_help"),
         SEND_CODE_WITH_TEXT("send_code_with_text"),
         SUBMIT_2FA_CODE("submit_2fa_code"),
-        CLICK_ON_LOGIN_SITE("click_on_login_site"),
         REQUEST_MAGIC_LINK("request_magic_link"),
         LOGIN_WITH_PASSWORD("login_with_password"),
         CREATE_NEW_SITE("create_new_site"),

diff --git a/WordPress/src/main/java/org/wordpress/android/ui/accounts/login/LoginAnalyticsTracker.java b/WordPress/src/main/java/org/wordpress/android/ui/accounts/login/LoginAnalyticsTracker.java
@@ -77,7 +77,6 @@ public void trackLoginForgotPasswordClicked() {
     @Override
     public void trackLoginMagicLinkExited() {
         AnalyticsTracker.track(AnalyticsTracker.Stat.LOGIN_MAGIC_LINK_EXITED);
-        mUnifiedLoginTracker.trackClick(Click.USE_PASSWORD_INSTEAD);
     }
 
     @Override
@@ -304,11 +303,6 @@ public void trackSubmit2faCodeClicked() {
         mUnifiedLoginTracker.trackClick(Click.SUBMIT_2FA_CODE);
     }
 
-    @Override
-    public void trackClickOnLoginSiteClicked() {
-        mUnifiedLoginTracker.trackClick(Click.CLICK_ON_LOGIN_SITE);
-    }
-
     @Override
     public void trackSubmitClicked() {
         mUnifiedLoginTracker.trackClick(Click.SUBMIT);

diff --git a/.../WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginAnalyticsListener.java b/.../WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginAnalyticsListener.java
@@ -58,8 +58,6 @@ public interface LoginAnalyticsListener {
 
     void trackSubmit2faCodeClicked();
 
-    void trackClickOnLoginSiteClicked();
-
     void trackSubmitClicked();
 
     void trackRequestMagicLinkClick();

diff --git a/...ogin/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginEmailFragment.java b/...ogin/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginEmailFragment.java
@@ -256,7 +256,6 @@ public void onClick(View view) {
         siteLoginButton.setOnClickListener(new OnClickListener() {
             @Override
             public void onClick(View view) {
-                mAnalyticsListener.trackClickOnLoginSiteClicked();
                 if (mLoginListener != null) {
                     LoginMode loginMode = mLoginListener.getLoginMode();
                     if (loginMode == LoginMode.JETPACK_STATS) {