Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: the "No comments yet" text is a bit lost at the bottom of the screen #13536

Closed
designsimply opened this issue Dec 4, 2020 · 7 comments · Fixed by #15259
Closed

Comments

@designsimply
Copy link
Contributor

Steps to reproduce:

  1. Go to Reader.
  2. Tap the comment icon for any post with comments enabled but doesn't have any comments yet.
  3. Observe that the "No comments yet" text is a bit lost at the bottom of the screen and no padding below the text makes the spacing of it awkward.

Screenshot_20201201-154711

Tested with WPAndroid 16.3-rc-2 on Pixel 3 Android 11.

@KirillPovarintsev
Copy link
Contributor

Is it better like this? Can I take care of the issue then?

Screenshot_1630035708

@chandradeepkumar16
Copy link

I am trying to fix the bug but the code changes are not being reflected in my emulator. Why?
I have followed the Readme file and successfully logged in with WordPress account.

@danmaze
Copy link
Contributor

danmaze commented Aug 30, 2021

Here's what I have:

image

I can't push the fix branch to create a pull request. It looks like I need some additional permissions.

@KirillPovarintsev
Copy link
Contributor

I thought I was the first one to grab it guys :)

@danmaze
Copy link
Contributor

danmaze commented Aug 30, 2021

No one has been assigned yet. Since you first indicated interest, you're probably going to get this one. :)

@KirillPovarintsev
Copy link
Contributor

Trying to obtain write permissions for the repo...

@ashiagr
Copy link
Contributor

ashiagr commented Aug 31, 2021

👋 @KirillPovarintsev

I've assigned this issue to you.

Trying to obtain write permissions for the repo...

You cannot directly merge changes to the main repo. Can you fork the repo and submit a PR? Let me know if you come across any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants