Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Site: Site Info Block - Site URL is cutoff when system font is set to largest setting #15172

Closed
zwarm opened this issue Aug 12, 2021 · 24 comments · Fixed by #15280
Closed

Comments

@zwarm
Copy link
Contributor

zwarm commented Aug 12, 2021

Expected behavior

The site URL should be fully visible in the site Info Block on the My Site view when the system font is set to the largest setting.

Actual behavior

The site URL is cutoff in the site Info Block on the My Site view when the system font is set to the largest setting.

Steps to reproduce the behavior

  • Set system font to highest setting on device
  • Open app
  • Navigate to My Site
  • Note the Site url is cutoff

###Screenshot###
Screen Shot 2021-08-12 at 8 35 34 AM

Tested on [Pixel 5], Android [11], WPAndroid [18.0-rc-1]
@namanrana16
Copy link
Contributor

I would like to take up this issue.

@chandradeepkumar16
Copy link

I would love to contribute to this project. I am a beginner and looking forward to contributing to the community

@ashiagr
Copy link
Contributor

ashiagr commented Aug 23, 2021

👋 @chandradeepkumar16,

Thanks for your interest in the project!

Since this issue is already assigned, can you take a look at this other issue #13536? Let me know if you have any questions regarding Project Setup or the Contributing Guide.

@namanrana16
Copy link
Contributor

@ashiagr I am having some problems with logging in, changed the OAuth ID and app secret but it persists.

@namanrana16
Copy link
Contributor

@ashiagr I am having some problems with logging in, changed the OAuth ID and app secret but it persists.

I am entering my ID but it still prompts currently unavailable, please enter the password.

@ashiagr
Copy link
Contributor

ashiagr commented Aug 30, 2021

Do you see any errors in the logs? What exact error are you seeing?

@namanrana16
Copy link
Contributor

BasicNetwork.performRequest: Unexpected response code 403 for https://public-api.wordpress.com/rest/v1.3/auth/send-login-email/?locale=en_IN

org.wordpress.android.prealpha E/WordPress-API: OnAuthEmailSent has error: GENERIC_ERROR - Invalid client_id.

org.wordpress.android.prealpha E/Volley: [268943] BasicNetwork.performRequest: Unexpected response code 403 for https://public-api.wordpress.com/rest/v1.3/auth/send-login-email/?locale=en_IN 2021-08-30 17:03:56.071 19687-19687/org.wordpress.android.prealpha E/WordPress-API: Volley error on https://public-api.wordpress.com/rest/v1.3/auth/send-login-email/?locale=en_IN com.android.volley.AuthFailureError

This is one of the errors.
When I enter my email and login it shows Currently Unavailable. Please enter your password.

@ashiagr
Copy link
Contributor

ashiagr commented Aug 30, 2021

Have you followed these instructions?https://github.com/wordpress-mobile/WordPress-Android#oauth2-authentication

@namanrana16
Copy link
Contributor

Yeah, I created the application in the app manager and changed the 2 Gradle properties mentioned.

@danmaze
Copy link
Contributor

danmaze commented Aug 30, 2021

I'm unable to replicate this issue. I'm testing on Pixel 3a, Android 11 and I set the system font to largest. I also tested on my Android device and the site URL doesn't cut off.

@chandradeepkumar16
Copy link

I am trying to fix the bug but the code changes are not being reflected in my emulator. Why?
I have followed the Readme file and even successfully logged in with WordPress account.

@namanrana16
Copy link
Contributor

namanrana16 commented Aug 30, 2021

When the name of the title is more than a single line then the URL is cut off.

@namanrana16
Copy link
Contributor

I am trying to fix the bug but the code changes are not being reflected in my emulator. Why?
I have followed the Readme file and even successfully logged in with WordPress account.

Can you help me as I am having trouble logging in even after changing the client ID and Secret.

@danmaze
Copy link
Contributor

danmaze commented Aug 30, 2021

When the name of the title is more than a single line then the URL is cut off.

Ah, I see. Thanks.

@ashiagr
Copy link
Contributor

ashiagr commented Aug 31, 2021

👋 @chandradeepkumar16

I am trying to fix the bug but the code changes are not being reflected in my emulator. Why?
I have followed the Readme file and even successfully logged in with WordPress account.

I might not be able to help without looking at your changes. Since this issue is already assigned, to avoid duplicating efforts, could you please work on this other issue (also mentioned in my earlier comment)?

I'd appreciate it if you can leave a comment before I assign it to you.

EDIT: My bad, #13536 is already taken. Can you take up this issue #15020?

@ashiagr
Copy link
Contributor

ashiagr commented Aug 31, 2021

👋 @namanrana16

Can you help me as I am having trouble logging in even after changing the client ID and Secret.

When I enter my email and login it shows Currently Unavailable. Please enter your password.

It seems you're trying to log in using the magic link. Can you share the email address you're using to log in with? I'm guessing you already have a WordPress.com account for the email address based on these instructions:

Note that credentials created with our WordPress.com applications manager
allow login only and not signup. New accounts must be created using the official app
or on the web. Login is restricted to the WordPress.com
account with which the credentials were created.

@namanrana16
Copy link
Contributor

Yes, I already have an account. My Email Id is namanrana1828@gmail.com.

@ashiagr
Copy link
Contributor

ashiagr commented Aug 31, 2021

Yes, I already have an account. My Email Id is namanrana1828@gmail.com.

All seems ok, can you retry? Or else set a password on the web and log in using email + password?

@namanrana16
Copy link
Contributor

WhatsApp Image 2021-08-31
WhatsApp Image 2021-08-31 at 12 22 57

This is the screen, there is no password field.

@ashiagr
Copy link
Contributor

ashiagr commented Aug 31, 2021

This is the screen, there is no password field.

You can go to https://wordpress.com/, login, and set a password from there.

@namanrana16
Copy link
Contributor

This is the screen, there is no password field.

You can go to https://wordpress.com/, login, and set a password from there.

It worked! Thanks a lot.

@namanrana16
Copy link
Contributor

namanrana16 commented Sep 3, 2021

@ashiagr I have solved the issue and am in the process of making a PR. How do I push the branch to GitHub as I am getting an error

ERROR: Permission to wordpress-mobile/WordPress-Android.git denied to namanrana16. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists.

@ashiagr
Copy link
Contributor

ashiagr commented Sep 3, 2021

@namanrana16, the repo is protected, you'll need to fork it and create a PR from it.

@namanrana16
Copy link
Contributor

@ashiagr I have created a PR. There are a couple of tasks that need to be taken care of but I don't know how to add labels, milestones, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants