Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler Warnings as Errors - WordPress Module - Glide (BaseTarget & ViewTarget) #17261

Open
Tracked by #17173
ParaskP7 opened this issue Oct 4, 2022 · 4 comments
Open
Tracked by #17173

Comments

@ParaskP7
Copy link
Contributor

ParaskP7 commented Oct 4, 2022

Parent #17173

This issue is about resolving the Glide compile warnings, related to BaseTarget and ViewTarget, for the WordPress module, and possibly, for the lib modules as well.

PS: Some of those warnings are already deprecated (see here).


See Glide guide.


For more info see:

@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

@surajmaity1
Copy link

surajmaity1 commented Oct 26, 2022

Hello @ParaskP7 👋, I want to work on this issue #17261 . Please assign this issue to me.

@ParaskP7
Copy link
Contributor Author

👋 @surajmaity1 and thank you so much for offering to contribute! 🥇

Please feel free to start working on this. As such, I'll go ahead and assign this task to you (and me). PS: I am assigning myself as well, as I'll be guiding you all the way, up until we collaboratively merge your solution to trunk.

Before you begin, make sure to at least read the following documentation:

  • README.md
    • Build Instructions (Step.2): You might notice that you would need to install npm. This is done for block editor related purposes (see gutenberg and gutenberg-mobile). The block editor is all React Native and as such this is a requirement for when working on it, especially for testing purposes. However, feel free to skip this step, that is, until you need it. PS: Most probably you won't be needing it for this task.
  • CONTRIBUTING.md
  • docs/coding-style.md

FYI: Note, depending on your solution, number of PRs, description on PRs, commit strategy, etc, I might ask you to improve on the quality and sometimes, even redo a PR. But, don't be afraid of it, I will only do that to help you out. Since this will be one of your first contribution to this repo, it is all part of the learning process, that is, until you become comfortable and aware about the ins-and-outs of how we work.

@surajmaity1
Copy link

Thanks a lot, @ParaskP7 for assigning this issue to me.🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants