Dependency Updates - Android Test Batch

[ParaskP7]

Parent #17551

This issue is about updating all Android Test related dependencies for the whole project.

This Android Test batch contains the following 3 dependencies:

• screengrabVersion = '2.1.1' (see docs) -> Comment
• squareupMockWebServerVersion = '2.7.5' (see okhttp tags) Update squareupMockWebServerVersion to 4.9.3 #17663
• wiremockVersion = '2.26.3' (see releases) -> Comment (skipped the update to 2.35.0 or 3.0.0-beta-2 due to its complexity)
• wiremockHttpClientVersion = '4.3.5.1' (❓) -> FYI Comment / We are already using the most recent version of this dependency

[peril-wordpress-mobile]

	Fails
🚫	Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

[peril-wordpress-mobile]

	Fails
🚫	Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

[peril-wordpress-mobile]

	Fails
🚫	Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

[ParaskP7]

✅ The latest stable version of screengrabVersion is 2.1.1 (see sonatype). As such, this item is now marked as complete.

[ParaskP7]

FYI: As part of this #17605 PR the main WireMock related apacheHttpClientAndroidVersion version got moved to the test section and renamed to wiremockHttpClientVersion (see commit).

Cc @oguzkocer

[oguzkocer]

The most recent wiremockHttpClientVersion (org.apache.httpcomponents:httpclient-android) in Maven Central is 4.3.5.1 which is the version we use at the time of this comment. So, we can mark that one as done.

Here is a screenshot showing that we are fetching this dependency from Maven Central:

[ParaskP7]

❌ After trying to update wiremockVersion to either the latest 2.35.0 or even 3.0.0-beta-2 version, the update proved much more complicated for it to be tackled just as part of this dependency update work.

1. First and foremost, updating to 2.35.0 required the app to be on a minSdkVersion = 26 while we are currently at 24, see error: com.android.tools.r8.internal.a2: MethodHandle.invoke and MethodHandle.invokeExact are only supported starting with Android O (--min-api 26)
2. Then, the WireMock dependency coordinates seems to have been long moved from com.github.tomakehurst:wiremock (latest being the 2.27.2) into com.github.tomakehurst:wiremock-jre8 (latest being 2.35.0). However, now, with the introduction of the newest beta (3.0.0-beta-2), the dependency coordinates are once more moved back to com.github.tomakehurst:wiremock. This make me think that the project is taking yet another turn and that we better wait until the 3.0.0 is ready before making any move on it.
3. By updating to either 2.35.0 or 3.0.0-beta-2, lots of compilation errors start popping-up. Those are mainly related to AssetFileSource.java and the BaseTest.java file, which is using that and the UnlocalizedDateHelper inner class to initialize a WireMockRule.

Suggestion (💡): When the project allows for this update (minSdkVersion = 26) and the newest stable library version becomes available (3.0.0-beta-2), my recommendation would be to completely start over with WireMock, from zero. Then, after setting up the default WireMock configuration and verifying it is working, we should build any custom features needed for our mocking framework to work on top of that newest version of WireMock. With that work, we might even consider removing the need for the mocks module altogether and move its assets into the WordPress module, under the androidTest source-set.

My hope is that with the above move a lot of mocks related complexity will be alleviated and the WireMock setup will be revisited. We might even consider re-evaluating this tool, maybe evaluate other tools and even migrate to such other tool (ie. MockWebServer). Until then, I recommend we hold-off on updating this library in order to avoid spending any unnecessary time fixing something that is already working okay for our needs. 🤔

Cc @oguzkocer @pachlava