Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: can't import #7252

Closed
AndroidDeveloperLB opened this issue Feb 18, 2018 · 8 comments
Closed

Bug: can't import #7252

AndroidDeveloperLB opened this issue Feb 18, 2018 · 8 comments

Comments

@AndroidDeveloperLB
Copy link

Expected behavior

Be able to build the project just fine, after importing it

Actual behavior

Has a build error:
image

Steps to reproduce the behavior

clone the project and open it.

Tested on [device], Android [version]

IDE:
Android Studio 3.2 Canary 3
Build #AI-173.4595177, built on February 9, 2018
JRE: 1.8.0_152-release-1024-b02 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

@rachelmcr
Copy link
Member

Please be sure to copy the gradle.properties-example file to gradle.properties — step 3 in the build instructions. :)

@AndroidDeveloperLB
Copy link
Author

Why does it have build instructions?
Why not clone and build, like any other normal repo?
Anyway, now that I've read it, I can't find where is the "gradle.properties" file on step #3. This file doesn't exist. What does it even mean to copy it ? Copy its content? Copy by creating a new file somewhere and putting the content there?

@catehstn
Copy link
Contributor

catehstn commented Mar 6, 2018

It's in the top level project directory: https://github.com/wordpress-mobile/WordPress-Android/blob/develop/gradle.properties-example

Unfortunately with complex projects you can't always clone and build, but some setup is required - especially relating to things (e.g. API keys) that can't just be checked into GitHub.

@AndroidDeveloperLB
Copy link
Author

AndroidDeveloperLB commented Mar 6, 2018

@catehstn Your link points to "gradle.properties-example" file . This I already found, and didn't write about it.
What I ask about is "gradle.properties".

Also, a sample project doesn't have to be complex. In fact, I'd always prefer to have a minimal sample, to get to know the library, and if there are more features, either have an additional sample, or have a way inside to get to advanced stuff.
In any case, whether it's complex or not, it shouldn't annoy when importing. It should be import&build right away. Shouldn't need us to mess with the files.

@catehstn
Copy link
Contributor

catehstn commented Mar 9, 2018

@AndroidDeveloperLB right, you need to copy that file to make the gradle.properties file, as per this comment.

This isn't a sample project? This is an actively developed, complex application. It's also not a library.

@AndroidDeveloperLB
Copy link
Author

Oh I was hoping it has a library somewhere within, for rich-text editing.
Can you please modularize it, so that the part of rich-text-editing would be on a different repository?

@rachelmcr
Copy link
Member

You can find the rich-text editor component that's used in the WordPress app (code name Aztec) in this repository:

https://github.com/wordpress-mobile/AztecEditor-Android

@AndroidDeveloperLB
Copy link
Author

@rachelmcr Thank you. Sadly I've found an issue with it, so I've reported here:
wordpress-mobile/AztecEditor-Android#643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants