Automatically upload local drafts and locally changed posts and pages

[shiki]

Closes #10174.

• ⚠️ This requires Rename LocalDraftUploadStarter to UploadStarter #10172 to be reviewed and merged first.
• ⚠️ The companion FluxC PR, Add methods for getting locally changed Posts and Pages WordPress-FluxC-Android#1303, should also be reviewed first.

Summary

When the LocalDraftUploadStarter was created in #9774, it was only uploading local draft posts, and later on, pages. The reasons for this were:

• I wanted to test out the implementation first and see how it works.
• I wasn't sure whether we should support this for other statuses. There were still some discussions going on.

Today, it looks like we can now safely do this. This change makes it so that all local drafts and all posts and pages that are locally changed will be automatically uploaded. Based on some testing, this is what iOS does today.

Testing

1. Go offline.
2. Create or edit posts and pages to end up with different statuses:
   • Local draft
   • Existing draft with changes
   • Existing uploaded post/page with changes
3. Go online.

Confirm that all are automatically uploaded.

Reviewing

Only 1 reviewer is needed but anyone can review.

Release Notes

• If there are user-facing changes, I have added an item to RELEASE-NOTES.txt.

Other Tasks

• If Add methods for getting locally changed Posts and Pages WordPress-FluxC-Android#1303 is approved and merged, the fluxCVersion should be updated to the develop version.

[malinajirka]

Thanks @shiki for the changes!

The code seems to work as intended. However, I'm a bit confused whether this is the behavior we wanted. I thought we'd publish changes only after user's explicit confirmation, but the app publishes all the changes, right?

The behavior I expected is following

1. Local drafts and locally changed drafts -> upload automatically
2. Published post with local changes - user did not click on "publish/update" -> automatically auto save
3. Published post with local changes - user clicked on "publish/update" -> upload automatically
4. I'm not sure what was our final decision for scheduled posts

Another thing I'm wondering about is if we need to somehow make sure the post we are about to upload isn't being edited at the moment. I'm not sure about this, I just wanted to bring it to the table so we can think about it.

Let me know your thoughts ;)

[malinajirka]

Btw I believe this task shouldn't be merged without #10207. We might want to merge it into a working branch. Wdyt?

[shiki]

@malinajirka That sounds right. I was planning to split this into multiple PRs so we're more careful of what should get automatically uploaded. I haven't thought more about it yet. I'll let you know.

[malinajirka]

I'm not sure where to note this so we don't forget about it. I'll just post it here.You might be planning or have already fixed this, but just to be sure.

I believe we'll need to modify this statement when we start publishing posts automatically so we bump the tracks when a post isn't uploaded because the device is offline and is uploaded automatically later.

[shiki]

Will just close this for now as this will most probably be split into multiple PRs. There will be upcoming discussions for this too.

[peril-wordpress-mobile]

	Warnings
⚠️	PR is not assigned to a milestone.

Generated by 🚫 dangerJS