Fix gradle bundle naming #10696
Merged
Fix gradle bundle naming #10696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good to me, but it seems that we need to update the CircleCI script as well due to the changes to the file names. |
jkmassel
force-pushed
the
fix/gradle-bundle-naming
branch
from
6a80ca6
to
eff8b1d
Compare
|
You can test the changes on this Pull Request by downloading the APK here. |
jkmassel
force-pushed
the
fix/gradle-bundle-naming
branch
from
eff8b1d
to
59d36a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue causing builds not to succeed – you can test this by checking out
release/13.5and runningbundle exec fastlane build_pre_releases. This issue was most likely introduced by #10583 – it appears Gradle changed how it names bundles by default.This PR fixes the issue by explicitly specifying
archivesBaseNamerather than relying on the Gradle default, which should prevent the issue from recurring.Additionally, extra error handling has been added in order to make this issue easier to track down in the future if it comes up again.
To test:
Run
bundle exec fastlane build_pre_releasesin this branch. It should succeed.PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.