Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Login & Sign-Up: Create Sign-Up From Login functionality for Email + Magic Link method #11708

Merged
merged 2 commits into from
Apr 21, 2020

Conversation

renanferrari
Copy link
Member

Part of #11705

To test

Full Flow

  1. Clear app data.
  2. On the Prologue Screen, tap Log In.
  3. If the Smart Lock dialog appears, dismiss it.
  4. On the Email Screen, enter an email address that is not associated with a WordPress.com account.
  5. Tap Next.
  6. Notice the Sign-Up Magic Link screen.
  7. Check email inbox of address used in Step 3.
  8. Notice signup email from WordPress.com.
  9. Complete the sign-up flow normally.

Jetpack Flow

  1. Log in with a self-hosted site that is not associated with a WordPress.com account.
  2. Go to My Site tab and tap Stats (or go to Notifications tab).
  3. Tap the Install Jetpack button.
  4. If the Smart Lock dialog appears, dismiss it.
  5. On the Email Screen, notice there's no Don't have an account? Sign up button.
  6. Enter an email address that is not associated with a WordPress.com account.
  7. Tap Next.
  8. Notice the Sign-Up Magic Link screen.
  9. Check email inbox of address used in Step 3.
  10. Notice signup email from WordPress.com.
  11. Complete the sign-up flow normally.

Notes

  • This doesn't add the Sign-Up From Login functionality for the Google Sign-In method just yet. This will be done in the following PR.
  • This also doesn't remove the Sign-Up button from the Prologue screen. This will be addressed in a future task.
  • Lastly, this also doesn't change the current labels used by the flows, so it may not always make sense.
  • This PR make changes to the LoginFlow library. These changes will probably need to be merged to the LoginFlow library once our feature branch gets merged back to develop.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

Messages
📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps!
WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history!

  1. cd WordPress-Android
  2. git checkout issue/11705-magic-link
  3. git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/WordPress-Android/11708
  4. Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/WordPress-Android/11708 and open a new PR.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@planarvoid planarvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good 👍. I was able to test the first flow and it works well. I couldn't get a self-hosted site to test the Jetpack signup because the site generator doesn't work. I'll merge the PR after I test it.

@planarvoid
Copy link
Contributor

I was able to test the flow with a self-hosted site and it works well 👍

@planarvoid planarvoid merged commit 2267bb8 into feature/unified-login-signup Apr 21, 2020
@planarvoid planarvoid deleted the issue/11705-magic-link branch April 21, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants