Added Swipe feature with onPostSwipeListener in Posts Activity and bug Fix #456 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aagam-shah A few things on the swiping patch:
After trying it out I think having a way to navigate through the posts is nice, but it needs some kinds of animation so the user knows what just happened. I think the Gmail app does this well with a 'wipe' animation. |
|
@roundhill The Gmail app uses ViewPager class which already has inbuilt animation - http://developer.android.com/training/animation/screen-slide.html . Yes,it would really look nice if this is implemented in WP-Android.So what's your opinion !!! |
|
You can certainly have a try at it if you'd like, but it might be too much work for just this one feature. Up to you. |
maxme
pushed a commit
that referenced
this pull request
Mar 15, 2016
Fix #9: add http auth to XMLRPC requests
mufela
added a commit
to mufela/WordPress-Android
that referenced
this pull request
Dec 5, 2016
aforcier
added a commit
that referenced
this pull request
Apr 15, 2019
aec79e59e2 Merge pull request #14 from wordpress-mobile/merge-wca 58ff2a2c8e Revert gradle plugin version update 38ba0160b0 Merge commit 'b7d105538004776cc4f7e83fae83136d48d29e90' into update-login-lib cfc89d9ba0 Merge pull request #12 from wordpress-mobile/merge-wpa 04bcfb3028 Update default login lib FluxC branch f5c678ca52 Merge commit '4cd695bb51cd7d26364e30e4986b14a48e854b0d' into update-login-subtree 5647062940 Username/password login on email_login_not_allowed 6309b4caea Add image illustration email alert 2ab920a545 Rename background color resources b89d1a9e81 Rename color from action mode status bar tint to status bar action mode 4c94f3c511 Rename color from status bar tint to status bar 9d910786ea Update color references from white to android resource e937a741b1 Merge commit '6e839250c045708ce14c430fd22981def2a87e61' into feature/update-login-library 9e8634fa2c Upgrade from 4.6 to gradle version 4.10.1 ebe32d22e1 Ensure mOldSitesIDs is created 0e7433ebf3 Use a default progress message to avoid resources not found exception 0d01e95fd9 Update build tools to 28.0.3 330a9cde65 Update to Gradle plugin 3.2.1 5eee6ef87d Rename login magic link image asset 9cb3c4d458 Fix NPE crash by disregarding email hint result if fragment view not init git-subtree-dir: libs/login git-subtree-split: aec79e59e2e34665a6e300c666a7c40312a5da3d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.