New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shared reader css file #12213
Use shared reader css file #12213
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
For iOS I implemented a class to manage that: I know this is not optimal and ideally, the server should handle that but is enough for now. Although I'm really not sure about the amount of time. |
Thanks for the review!!!
Thanks for the info, I'll implement the same class on Android;). Definitely way better than manual updating:). |
Fixes #11673
Fixes #7636
Fixes #11685
Fixes #11779 (I believe it's desired behavior)
The main goal of this PR is to use mobile specific (shared) css file for rendering posts in the Reader. The css file is heavily based on Calypso's Reader css file. This PR also changes some of the hardcoded styles to fix some minor issues.
Questions:
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.