Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strings in release/16.6 #13883

Merged
merged 1 commit into from Jan 27, 2021
Merged

Conversation

loremattei
Copy link
Contributor

Translators noticed that some strings which reference other strings resources have been sent to GlotPress.
I think the only issue with those is that they miss the translatable=false attribute, so this PR adds it.

Adding @zwarm and @malinajirka as reviewers to make sure this is the expected behaviour.

After this PR is merged, we'll need to merge the release branch into develop to update GlotPress.

cc @JavonDavis.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loremattei - Works as expected. Thanks for catching this.

@loremattei loremattei changed the base branch from release/16.6 to develop January 27, 2021 14:55
@loremattei loremattei changed the base branch from develop to release/16.6 January 27, 2021 14:56
@loremattei loremattei merged commit ad58c88 into release/16.6 Jan 27, 2021
@loremattei loremattei deleted the fix/untranslatable-strings branch January 27, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants