Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/14299 add payload to fetch sites wp module #14397

Merged
merged 4 commits into from
Apr 6, 2021

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Apr 5, 2021

Issue: #14299

This PR adds an empty FetchSitesPayload to newFetchSitesAction as part of the Jetpack app filters support in the fetch sites API.

Related PRs:
wordpress-mobile/WordPress-FluxC-Android#1936
#14356

To test:

  • Launch and login to app
  • Go to My Sites tab
  • Notice that all sites for the user are shown on the Site Picker

Merge Instructions:

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ashiagr ashiagr self-assigned this Apr 5, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 5, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 5, 2021

Messages
📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps!
WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history!

  1. cd WordPress-Android
  2. git checkout issue/14299-add-payload-to-fetch-sites-wp-module
  3. git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/WordPress-Android/14397
  4. Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/WordPress-Android/14397 and open a new PR.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 5, 2021

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @ashiagr !

I have reviewed and tested this PR as per the instructions, everything looks as expected, good job! 🌟

PS: As per your merge instruction we need to create a FluxC tag before merging.

@ashiagr ashiagr merged commit fda6b1f into develop Apr 6, 2021
@ashiagr ashiagr deleted the issue/14299-add-payload-to-fetch-sites-wp-module branch April 6, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants