Improved swiping through notifications behaviour #15253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssinha2103
commented
Aug 30, 2021
WordPress/src/main/res/layout/notifications_detail_activity.xml
Outdated
Show resolved
Hide resolved
ashiagr
reviewed
Aug 30, 2021
There was a problem hiding this comment.
Thank you for working on this @ssinha2103!
Looks nice in the light mode. Needs some adjustments in the dark mode. Instead of white, can you try a darker background in the dark mode?
ssinha2103
commented
Aug 30, 2021
ssinha2103
commented
Aug 30, 2021
ashiagr
added
the
[Status] Needs Design Review
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
ashiagr
removed
the
[Status] Needs Design Review
|
You can test the changes on this Pull Request by downloading the APKs: |
ashiagr
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #14919
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.