Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update login lib - no user-facing changes #15436

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Update login lib - no user-facing changes #15436

merged 1 commit into from
Oct 12, 2021

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Oct 8, 2021 •
edited

Merges changes made in wordpress-mobile/WordPress-Login-Flow-Android#71 and wordpress-mobile/WordPress-Login-Flow-Android#69 into WPAndroid.

The changes can be seen here.

To test:

  1. Clear app data
  2. Start "enter site address" login flow
  3. Enable "Don't keep activities" in developer settings
  4. Bring the app back to foreground and notice it doesn't crash
  5. Go back and start ".com login flow"
  6. Make sure the TOS link color hasn't changed (the change affects only Woo android since primaryColor and secondaryColor are identical in WPAndroid/Jetpack repo)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@malinajirka malinajirka added this to the 18.5 milestone Oct 8, 2021
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@rossanafmenezes rossanafmenezes mentioned this pull request Oct 8, 2021
Merged
1 task
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@malinajirka malinajirka marked this pull request as ready for review October 8, 2021 13:07
ravishanker
ravishanker approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this @malinajirka 👍

@ravishanker ravishanker merged commit bd3e97d into develop Oct 12, 2021
@ravishanker ravishanker deleted the update-login-lib branch October 12, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravishanker ravishanker ravishanker approved these changes

Assignees
No one assigned
Labels
Login [Pri] Blocking
Projects
None yet
Milestone
18.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malinajirka @ravishanker