Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow conversation by push notification. #15459

Merged
merged 36 commits into from Oct 15, 2021
Merged

Follow conversation by push notification. #15459

merged 36 commits into from Oct 15, 2021

Commits on Oct 14, 2021

  1. Add bell icon.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    81b18e3 View commit details
    Browse the repository at this point in the history

  2. Adding selector for menu disabled state.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    9d7e8a4 View commit details
    Browse the repository at this point in the history

  3. Adding string resources.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    c90b837 View commit details
    Browse the repository at this point in the history

  4. Adding secondary button style.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    b50dc32 View commit details
    Browse the repository at this point in the history

  5. Adding dimension resources.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    eb2c6be View commit details
    Browse the repository at this point in the history

  6. Adding threaded comments menu resource.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    5ce5422 View commit details
    Browse the repository at this point in the history

  7. Adding feature config.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    3876c30 View commit details
    Browse the repository at this point in the history

  8. Adjust network response parsing and add function to manage push subsc… 

    …ription.
    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    96e2ec2 View commit details
    Browse the repository at this point in the history

  9. Adding push notification function to use case and handler.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    7a91675 View commit details
    Browse the repository at this point in the history

  10. Changing default visibility for following button.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    e8be60f View commit details
    Browse the repository at this point in the history

  11. Adding push notification functions to view model.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    e982bee View commit details
    Browse the repository at this point in the history

  12. Creating bottom sheet for follow conversation management.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    a04bbeb View commit details
    Browse the repository at this point in the history

  13. Adding follow conversation management menu.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    b36b037 View commit details
    Browse the repository at this point in the history

  14. Fixing unit testing.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    f5dc0b3 View commit details
    Browse the repository at this point in the history

  15. Fixing linter.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    e9027d2 View commit details
    Browse the repository at this point in the history

  16. Fixing build.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    39aff40 View commit details
    Browse the repository at this point in the history

  17. Removing unused dimension.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    8a49521 View commit details
    Browse the repository at this point in the history

  18. Removed commented section.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    3a8933c View commit details
    Browse the repository at this point in the history

  19. File reformatted.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    bccbd56 View commit details
    Browse the repository at this point in the history

  20. Extracting strings into constants.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    b66b4a6 View commit details
    Browse the repository at this point in the history

  21. Using named arguments for Success parameters.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    ed5d7d6 View commit details
    Browse the repository at this point in the history

  22. Refactoring access to function parameters.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    fed5c60 View commit details
    Browse the repository at this point in the history

  23. Refactored onCreate as per review feedback.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    7a2956f View commit details
    Browse the repository at this point in the history

  24. Refactored onViewCreated as per review feedback.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    252413d View commit details
    Browse the repository at this point in the history

  25. Moved vals to consts.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    e6c661d View commit details
    Browse the repository at this point in the history

  26. Fixing typo.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    0f5b8d6 View commit details
    Browse the repository at this point in the history

  27. Refactor to move a bit of logic in VM.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    cd5e35d View commit details
    Browse the repository at this point in the history

  28. Merge branch 'develop' into feature/follow-by-notification

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    9c2964c View commit details
    Browse the repository at this point in the history

  29. Fixing detekt.

    @develric
    develric committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    fef8a95 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Adding unit testing to ReaderCommentListViewModelTest.

    @develric
    develric committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    54d53f8 View commit details
    Browse the repository at this point in the history

  2. Adding unit testing to ReaderFollowCommentsHandler.

    @develric
    develric committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    4861150 View commit details
    Browse the repository at this point in the history

  3. More unit testing to ReaderFollowCommentsHandler.

    @develric
    develric committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    5c52fd2 View commit details
    Browse the repository at this point in the history

  4. Adding unit testing to ReaderCommentsFollowUseCaseTest.

    @develric
    develric committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    bfd6134 View commit details
    Browse the repository at this point in the history

  5. Updating release notes.

    @develric
    develric committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    ccb51c7 View commit details
    Browse the repository at this point in the history

  6. Enabling the feature flag.

    @develric
    develric committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    5813fe0 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #15469 from wordpress-mobile/feature/follow-by-not… 

    …ification-enable

Follow by notification enable feature flag
    @develric
    develric committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    fe94325 View commit details
    Browse the repository at this point in the history