Posts List: Add Copy link functionality for posts

WordPress/src/main/java/org/wordpress/android/ui/posts/PostActionHandler.kt

@@ -29,12 +29,12 @@ import org.wordpress.android.ui.posts.RemotePreviewLogicHelper.RemotePreviewType
 import org.wordpress.android.ui.uploads.UploadService
 import org.wordpress.android.ui.uploads.UploadUtils
 import org.wordpress.android.ui.utils.UiString.UiStringRes
-import org.wordpress.android.util.ToastUtils
 import org.wordpress.android.util.ToastUtils.Duration
 import org.wordpress.android.viewmodel.helpers.ToastMessageHolder
 import org.wordpress.android.widgets.PostListButtonType
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_CANCEL_PENDING_AUTO_UPLOAD
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_COPY
+import org.wordpress.android.widgets.PostListButtonType.BUTTON_COPY_URL
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_DELETE
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_DELETE_PERMANENTLY
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_EDIT
@@ -98,7 +98,7 @@ class PostActionHandler(
                             showToast = showToast,
                             messageMediaUploading = ToastMessageHolder(
                                     R.string.editor_toast_uploading_please_wait,
-                                    ToastUtils.Duration.SHORT
+                                    Duration.SHORT
                             )
                     )
             )
@@ -115,6 +115,7 @@ class PostActionHandler(
                 }
             }
             BUTTON_COPY -> copyPost(site, post, true)
+            BUTTON_COPY_URL -> triggerPostListAction.invoke(copyUrlAction(post))
             BUTTON_DELETE, BUTTON_DELETE_PERMANENTLY -> {
                 postListDialogHelper.showDeletePostConfirmationDialog(post)
             }
@@ -129,6 +130,20 @@ class PostActionHandler(
         }
     }
 
+    private fun copyUrlAction(post: PostModel) = PostListAction.CopyUrl(
+            site = site,
+            post = post,
+            showToast = showToast,
+            messageSuccess = ToastMessageHolder(
+                    R.string.post_link_copied_to_clipboard,
+                    Duration.SHORT
+            ),
+            messageError = ToastMessageHolder(
+                    R.string.error_copy_to_clipboard,
+                    Duration.SHORT
+            )
+    )
+
     private fun cancelPendingAutoUpload(post: PostModel) {
         val msgRes = UploadUtils.cancelPendingAutoUpload(post, dispatcher)
         showSnackbar.invoke(SnackbarMessageHolder(UiStringRes(msgRes)))

WordPress/src/main/java/org/wordpress/android/ui/posts/PostListAction.kt

@@ -1,5 +1,6 @@
 package org.wordpress.android.ui.posts
 
+import android.content.ClipData
 import androidx.fragment.app.FragmentActivity
 import org.wordpress.android.fluxc.model.PostModel
 import org.wordpress.android.fluxc.model.SiteModel
@@ -11,6 +12,8 @@ import org.wordpress.android.ui.posts.RemotePreviewLogicHelper.RemotePreviewType
 import org.wordpress.android.ui.prefs.AppPrefs
 import org.wordpress.android.ui.stories.intro.StoriesIntroDialogFragment
 import org.wordpress.android.ui.uploads.UploadService
+import org.wordpress.android.util.AppLog
+import org.wordpress.android.util.clipboardManager
 import org.wordpress.android.viewmodel.helpers.ToastMessageHolder
 
 sealed class PostListAction {
@@ -33,6 +36,13 @@ sealed class PostListAction {
         val post: PostModel,
         val trackAnalytics: Boolean = PostUtils.isFirstTimePublish(post)
     ) : PostListAction()
+    class CopyUrl(
+        val site: SiteModel,
+        val post: PostModel,
+        val showToast: (ToastMessageHolder) -> Unit,
+        val messageSuccess: ToastMessageHolder,
+        val messageError: ToastMessageHolder
+    ) : PostListAction()
 
     class ViewStats(val site: SiteModel, val post: PostModel) : PostListAction()
     class ViewPost(val site: SiteModel, val post: PostModel) : PostListAction()
@@ -91,5 +101,16 @@ fun handlePostListAction(
         is PostListAction.DismissPendingNotification -> {
             NativeNotificationsUtils.dismissNotification(action.pushId, activity)
         }
+        is PostListAction.CopyUrl -> {
+            try {
+                activity.clipboardManager!!.setPrimaryClip(
+                        ClipData.newPlainText("${action.post.id}", action.post.link)
+                )
+                action.showToast.invoke(action.messageSuccess)
+            } catch (e: Exception) {
+                AppLog.e(AppLog.T.POSTS, e)
+                action.showToast.invoke(action.messageError)
+            }
+        }
     }
 }

WordPress/src/main/java/org/wordpress/android/ui/posts/PostListActionTracker.kt

@@ -7,6 +7,7 @@ import org.wordpress.android.util.analytics.AnalyticsUtils
 import org.wordpress.android.widgets.PostListButtonType
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_CANCEL_PENDING_AUTO_UPLOAD
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_COPY
+import org.wordpress.android.widgets.PostListButtonType.BUTTON_COPY_URL
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_DELETE
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_DELETE_PERMANENTLY
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_EDIT
@@ -49,6 +50,7 @@ fun trackPostListAction(site: SiteModel, buttonType: PostListButtonType, postDat
         BUTTON_MOVE_TO_DRAFT -> "move_to_draft"
         BUTTON_CANCEL_PENDING_AUTO_UPLOAD -> "cancel_pending_auto_upload"
         BUTTON_SHOW_MOVE_TRASHED_POST_TO_DRAFT_DIALOG -> "show_move_trashed_post_to_draft_post_dialog"
+        BUTTON_COPY_URL -> "copy_url"
     }
 
     AnalyticsUtils.trackWithSiteDetails(statsEvent, site, properties)

WordPress/src/main/java/org/wordpress/android/util/ContextExtensions.kt

@@ -1,5 +1,6 @@
 package org.wordpress.android.util
 
+import android.content.ClipboardManager
 import android.content.Context
 import android.content.res.ColorStateList
 import android.util.TypedValue
@@ -41,3 +42,10 @@ fun Context.getColorStateListFromAttribute(@AttrRes attribute: Int): ColorStateL
 // https://developer.android.com/reference/android/content/res/Configuration.html#locale
 val Context.currentLocale: Locale
     get() = ConfigurationCompat.getLocales(resources.configuration)[0]
+
+/**
+ * Gets the clipboard manager system service
+ * @see android.content.ClipboardManager
+ */
+val Context.clipboardManager: ClipboardManager?
+    get() = ContextCompat.getSystemService(this, ClipboardManager::class.java)

WordPress/src/main/java/org/wordpress/android/viewmodel/posts/PostListItemUiStateHelper.kt

@@ -46,6 +46,7 @@ import org.wordpress.android.viewmodel.uistate.ProgressBarUiState
 import org.wordpress.android.widgets.PostListButtonType
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_CANCEL_PENDING_AUTO_UPLOAD
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_COPY
+import org.wordpress.android.widgets.PostListButtonType.BUTTON_COPY_URL
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_DELETE
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_DELETE_PERMANENTLY
 import org.wordpress.android.widgets.PostListButtonType.BUTTON_EDIT
@@ -156,7 +157,7 @@ class PostListItemUiStateHelper @Inject constructor(
                         uploadUiState = uploadUiState,
                         performingCriticalAction = performingCriticalAction
                 ),
-                disableRippleEffect = postStatus == PostStatus.TRASHED
+                disableRippleEffect = postStatus == TRASHED
         )
 
         return PostListItemUiState(
@@ -380,7 +381,8 @@ class PostListItemUiStateHelper @Inject constructor(
                 !isLocalDraft &&
                 !isLocallyChanged
         val canShowCopy = postStatus == PUBLISHED || postStatus == DRAFT
-        val canShowViewButton = !canRetryUpload && postStatus != PostStatus.TRASHED
+        val canShowCopyUrlButton = postStatus == PUBLISHED && !isLocalDraft
+        val canShowViewButton = !canRetryUpload && postStatus != TRASHED
         val canShowPublishButton = canRetryUpload || canPublishPost
         val buttonTypes = ArrayList<PostListButtonType>()
 
@@ -394,14 +396,11 @@ class PostListItemUiStateHelper @Inject constructor(
 
         if (canShowPublishButton) {
             buttonTypes.add(
-                    if (canRetryUpload) {
-                        BUTTON_RETRY
-                    } else if (!siteHasCapabilitiesToPublish) {
-                        BUTTON_SUBMIT
-                    } else if (postStatus == SCHEDULED && isLocallyChanged) {
-                        BUTTON_SYNC
-                    } else {
-                        BUTTON_PUBLISH
+                    when {
+                        canRetryUpload -> BUTTON_RETRY
+                        !siteHasCapabilitiesToPublish -> BUTTON_SUBMIT
+                        postStatus == SCHEDULED && isLocallyChanged -> BUTTON_SYNC
+                        else -> BUTTON_PUBLISH
                     }
             )
         }
@@ -426,6 +425,8 @@ class PostListItemUiStateHelper @Inject constructor(
 
         buttonTypes.addMoveToDraftActionIfAvailable(postStatus)
 
+        buttonTypes.addIf(canShowCopyUrlButton, BUTTON_COPY_URL)
+
         when {
             isLocalDraft -> buttonTypes.add(BUTTON_DELETE)
             postStatus == TRASHED -> {
@@ -437,6 +438,12 @@ class PostListItemUiStateHelper @Inject constructor(
         return buttonTypes
     }
 
+    private fun MutableList<PostListButtonType>.addIf(condition: Boolean, buttonType: PostListButtonType) {
+        if (condition) {
+            add(buttonType)
+        }
+    }
+
     private fun MutableList<PostListButtonType>.addMoveToDraftActionIfAvailable(postStatus: PostStatus) {
         val canMovePostToDraft = postStatus == PUBLISHED || postStatus == TRASHED
 

WordPress/src/main/java/org/wordpress/android/widgets/PostListButtonType.kt

@@ -37,7 +37,8 @@ enum class PostListButtonType constructor(
             R.attr.wpColorWarningDark
     ),
     BUTTON_SHOW_MOVE_TRASHED_POST_TO_DRAFT_DIALOG(15, 0, 0, 0),
-    BUTTON_COPY(16, R.string.button_copy, R.drawable.ic_copy_white_24dp, R.attr.colorOnSurface);
+    BUTTON_COPY(16, R.string.button_copy, R.drawable.ic_copy_white_24dp, R.attr.colorOnSurface),
+    BUTTON_COPY_URL(17, R.string.button_copy_link, R.drawable.ic_gridicons_link_white_24dp, R.attr.colorOnSurface);
 
     companion object {
         fun fromInt(value: Int): PostListButtonType? = values().firstOrNull { it.value == value }

WordPress/src/main/res/drawable/ic_gridicons_link_white_24dp.xml

@@ -0,0 +1,9 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:viewportHeight="24"
+    android:viewportWidth="24">
+    <path
+        android:fillColor="@android:color/white"
+        android:pathData="M17.001,12.999H7.001V10.999H17.001V12.999ZM18.001,6.999H17.001C15.37,6.999 13.936,7.791 13.024,8.999H18.001C19.104,8.999 20.001,9.896 20.001,10.999V12.999C20.001,14.102 19.104,14.999 18.001,14.999H13.024C13.937,16.207 15.371,16.999 17.001,16.999H18.001C19.0618,16.999 20.0793,16.5776 20.8294,15.8275C21.5795,15.0773 22.001,14.0599 22.001,12.999V10.999C22.001,9.9382 21.5795,8.9207 20.8294,8.1706C20.0793,7.4205 19.0618,6.999 18.001,6.999ZM2.001,10.999V12.999C2.001,14.0599 2.4224,15.0773 3.1725,15.8275C3.9227,16.5776 4.9401,16.999 6.001,16.999H7.001C8.631,16.999 10.066,16.207 10.978,14.999H6.001C4.898,14.999 4.001,14.102 4.001,12.999V10.999C4.001,9.896 4.898,8.999 6.001,8.999H10.978C10.066,7.791 8.632,6.999 7.001,6.999H6.001C4.9401,6.999 3.9227,7.4205 3.1725,8.1706C2.4224,8.9207 2.001,9.9382 2.001,10.999V10.999Z" />
+</vector>

WordPress/src/main/res/values/strings.xml

@@ -309,6 +309,7 @@
     <string name="button_retry">Retry</string>
     <string name="button_move_to_draft">Move to Draft</string>
     <string name="button_copy">Duplicate</string>
+    <string name="button_copy_link">Copy link</string>
 
     <!-- post uploads -->
     <string name="upload_failed_param">Upload failed for \"%s\"</string>
@@ -504,6 +505,7 @@
     <string name="remove_account">Remove site</string>
 
     <!-- post actions -->
+    <string name="post_link_copied_to_clipboard">Link copied to clipboard</string>
     <string name="post_trashed">Post sent to trash</string>
     <string name="post_trashing">Post is being trashed</string>
     <string name="post_restored">Post restored</string>

WordPress/src/test/java/org/wordpress/android/viewmodel/posts/PostListItemUiStateHelperTest.kt

@@ -237,8 +237,9 @@ class PostListItemUiStateHelperTest {
         assertThat(moreActions[0].buttonType).isEqualTo(PostListButtonType.BUTTON_STATS)
         assertThat(moreActions[1].buttonType).isEqualTo(PostListButtonType.BUTTON_COPY)
         assertThat(moreActions[2].buttonType).isEqualTo(PostListButtonType.BUTTON_MOVE_TO_DRAFT)
-        assertThat(moreActions[3].buttonType).isEqualTo(PostListButtonType.BUTTON_TRASH)
-        assertThat(moreActions).hasSize(4)
+        assertThat(moreActions[3].buttonType).isEqualTo(PostListButtonType.BUTTON_COPY_URL)
+        assertThat(moreActions[4].buttonType).isEqualTo(PostListButtonType.BUTTON_TRASH)
+        assertThat(moreActions).hasSize(5)
     }
 
     @Test
@@ -256,8 +257,9 @@ class PostListItemUiStateHelperTest {
         assertThat(moreActions[0].buttonType).isEqualTo(PostListButtonType.BUTTON_PREVIEW)
         assertThat(moreActions[1].buttonType).isEqualTo(PostListButtonType.BUTTON_COPY)
         assertThat(moreActions[2].buttonType).isEqualTo(PostListButtonType.BUTTON_MOVE_TO_DRAFT)
-        assertThat(moreActions[3].buttonType).isEqualTo(PostListButtonType.BUTTON_TRASH)
-        assertThat(moreActions).hasSize(4)
+        assertThat(moreActions[3].buttonType).isEqualTo(PostListButtonType.BUTTON_COPY_URL)
+        assertThat(moreActions[4].buttonType).isEqualTo(PostListButtonType.BUTTON_TRASH)
+        assertThat(moreActions).hasSize(5)
     }
 
     @Test
@@ -277,8 +279,9 @@ class PostListItemUiStateHelperTest {
         val moreActions = (state.actions[2] as MoreItem).actions
         assertThat(moreActions[0].buttonType).isEqualTo(PostListButtonType.BUTTON_COPY)
         assertThat(moreActions[1].buttonType).isEqualTo(PostListButtonType.BUTTON_MOVE_TO_DRAFT)
-        assertThat(moreActions[2].buttonType).isEqualTo(PostListButtonType.BUTTON_TRASH)
-        assertThat(moreActions).hasSize(3)
+        assertThat(moreActions[2].buttonType).isEqualTo(PostListButtonType.BUTTON_COPY_URL)
+        assertThat(moreActions[3].buttonType).isEqualTo(PostListButtonType.BUTTON_TRASH)
+        assertThat(moreActions).hasSize(4)
     }
 
     @Test
@@ -380,8 +383,9 @@ class PostListItemUiStateHelperTest {
         assertThat(moreActions[0].buttonType).isEqualTo(PostListButtonType.BUTTON_PREVIEW)
         assertThat(moreActions[1].buttonType).isEqualTo(PostListButtonType.BUTTON_COPY)
         assertThat(moreActions[2].buttonType).isEqualTo(PostListButtonType.BUTTON_MOVE_TO_DRAFT)
-        assertThat(moreActions[3].buttonType).isEqualTo(PostListButtonType.BUTTON_TRASH)
-        assertThat(moreActions).hasSize(4)
+        assertThat(moreActions[3].buttonType).isEqualTo(PostListButtonType.BUTTON_COPY_URL)
+        assertThat(moreActions[4].buttonType).isEqualTo(PostListButtonType.BUTTON_TRASH)
+        assertThat(moreActions).hasSize(5)
     }
 
     @Test
@@ -467,8 +471,9 @@ class PostListItemUiStateHelperTest {
         assertThat(moreActions[0].buttonType).isEqualTo(PostListButtonType.BUTTON_RETRY)
         assertThat(moreActions[1].buttonType).isEqualTo(PostListButtonType.BUTTON_COPY)
         assertThat(moreActions[2].buttonType).isEqualTo(PostListButtonType.BUTTON_MOVE_TO_DRAFT)
-        assertThat(moreActions[3].buttonType).isEqualTo(PostListButtonType.BUTTON_TRASH)
-        assertThat(moreActions).hasSize(4)
+        assertThat(moreActions[3].buttonType).isEqualTo(PostListButtonType.BUTTON_COPY_URL)
+        assertThat(moreActions[4].buttonType).isEqualTo(PostListButtonType.BUTTON_TRASH)
+        assertThat(moreActions).hasSize(5)
     }
 
     @Test

config/detekt/baseline.xml

@@ -349,6 +349,7 @@
     <ID>TooGenericExceptionCaught:ColorUnderlineSpan.kt$ColorUnderlineSpan$e: Exception</ID>
     <ID>TooGenericExceptionCaught:GifMediaInsertUseCase.kt$GifMediaInsertUseCase$e: Exception</ID>
     <ID>TooGenericExceptionCaught:MediaPickerActivity.kt$MediaPickerActivity$e: RuntimeException</ID>
+    <ID>TooGenericExceptionCaught:PostListAction.kt$e: Exception</ID>
     <ID>TooGenericExceptionCaught:UploadStarter.kt$UploadStarter$e: Exception</ID>
     <ID>TooGenericExceptionThrown:ActionableEmptyView.kt$ActionableEmptyView$throw RuntimeException("$context: ActionableEmptyView must have a title (aevTitle)")</ID>
     <ID>TooGenericExceptionThrown:ActivityLogDetailFragment.kt$ActivityLogDetailFragment$throw Throwable("Couldn't initialize Activity Log view model")</ID>