New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing: Replace snackbar with compact notice when switching editor mode #15583
Editing: Replace snackbar with compact notice when switching editor mode #15583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ovitrif 👍
I tested this on an Pixel 5 (Android 12) and everything works as expected 🎉
The code changes are consistent and LGTM ✅
Thank you @antonis for the review! |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APKs: |
Fixes #11819
It was brought to our attention that some users find the snackbar appearing at the bottom of the screen when the editor mode is switched to HTML annoying because they cannot edit the last lines before it disappears.
This PR replaces the snackbar at the bottom with a compact notice shown at the top of the screen, below the main top bar of the app (see screenshots).
This solution was suggested after a discussion in the issue where we also explored the option of not showing any notice.
The snackbar is now replaced with the notice in both cases:
To test
Screenshots
Switching to HTML mode
Switching to Visual mode
GIF Preview
Regression Notes
Potential unintended areas of impact
None, because the snackbar that is replaced was only shown when switching editor mode, and now we show a notice instead.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing.
What automated tests I added (or what prevented me from doing so)
None, since this change does not warrant such tests.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.