-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update login lib hash that allows wpcom site address login for JetPack app #16025
Update login lib hash that allows wpcom site address login for JetPack app #16025
Conversation
👋 @AliSoftware, pinging you as this issue was noticed during |
You can test the changes on this Pull Request by downloading the APKs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashiagr - I reviewed and merged the Login Library changes. As per instructions, I'll leave this merge for you. 👍
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
I updated login lib version to trunk commit. I just realized I should have created a tag and updated that instead. Can you please confirm? |
Yes for code frozen branch we should indeed use a tag 🙇♂️ |
References: wordpress-mobile/WordPress-Login-Flow-Android#80
Now that
Jetpack
site filtering is removed as part ofJetpack App - Enable Features
(#15946), this PR updates login lib hash for a fix that matcheswpcom site address login
in theJetpack
app with theWordPress
app.CC @thehenrybyrd
To test:
Jetpack
app.Landing
screen.wpcom
simple
site address (note that theJetpack
app already allowedatomic
site address login earlier as it hasJetpack
installed, so make sure you specifically test awpcom
simple
site).Merge Instructions
This issue was noticed during beta testing 19.3-rc-1 (p5T066-31e-p2#comment-11484), and so targets
release/19.3
branch.trunk
. I can take care of the merging tomorrow.build.gradle
.Not Ready for Merge
label and merge the PR.Regression Notes
Potential unintended areas of impact
Minimal changes are included in the linked login lib PR that filters out
wpcom
sites from the connect site info handling for theJetpack
app. These sites are handled by the fallback method that redirects them toWordPress.com
email login similar to theWordPress
app.What I did to test those areas of impact (or what existing automated tests I relied on)
Tested manually.
What automated tests I added (or what prevented me from doing so)
Login lib does not support unit testing for this flow.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.