Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Start for Existing Users V2: Add new quick start task type #16473

Merged
merged 6 commits into from
May 6, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented May 4, 2022

Parent #16350

Corresponding FluxC PR: wordpress-mobile/WordPress-FluxC-Android#2376

This PR completes when branches for the newly added quick start task type / dynamic card type in FluxC so that the code compiles.

To test:

  • Launch the app with a site having a quick start in progress.
  • Make sure that tasks for only Customize and Grow quick start types are shown in the "Next Steps" card on My Site screen. Note that "Next Steps" card will be present either on Home or Menu tab based on Initial Screen settings.
  • Go to My Site -> Me -> App Settings -> Debug settings and enable QuickStartDynamicCardsFeatureConfig.
  • Restart the app.
  • Notice that dynamic cards are displayed only for dynamic card types corresponding to Customize and Grow tasks.

P.S.: I've left a few todos to add tracking and category completion message for the newly added task type. Added a task to the parent task to remove these todos.

Merge Instructions

  1. Make sure corresponding FluxC PR is merged to trunk (I can take care of merging and updating version) ✅
  2. Update FluxC version ✅
  3. Wait for known issue in Regression Notes to be fixed ✅ - 856e756
  4. Remove Not Ready for Merge label ✅
  5. Merge the PR ✅

Regression Notes

  1. Potential unintended areas of impact
    [A] Crashes or empty qs card (without tasks) display due to the introduction of a new task/ dynamic card type.
    [B] Impact on Quick Start completion.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  • For [A] - tested manually (See To test section)

  • For [B] - verified that isEveryQuickStartTaskDone() checks for done status for QuickStartTask.values() which do not contain any tasks for the newly added task type yet.

    Known Issue: Completion notification is shown for dynamic cards on selecting a site from Login Epilogue.

  1. What automated tests I added (or what prevented me from doing so)
  • Fixed FluxC existing tests for DynamicCardStore.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…_TO_KNOW_APP or DynamicCardType.GET_TO_KNOW_APP as needed

Added todos for analytics and category completion message
@ashiagr ashiagr added this to the 19.9 milestone May 4, 2022
@ashiagr ashiagr added this to In progress in [Android] Quick Start for Existing Users v2 via automation May 4, 2022
@ashiagr ashiagr self-assigned this May 4, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 4, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 4, 2022

You can test the changes on this Pull Request by downloading the APKs:

[Android] Quick Start for Existing Users v2 automation moved this from In progress to Reviewer approved May 5, 2022
Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashiagr I have looked at the code changes and tested it as per the instructions. Everything looks good to me. Good start on the new Quick start tasks. 👍 🙌

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

-+--- org.wordpress:fluxc:{strictly 2377-4413c7ddffab44db8419abe98815c85bf4376d34} -> 2377-4413c7ddffab44db8419abe98815c85bf4376d34
-|    +--- org.wordpress:wellsql:1.7.0
-|    |    \--- org.wordpress.wellsql:wellsql-annotations:1.7.0
-|    +--- org.wordpress.fluxc:fluxc-annotations:2377-4413c7ddffab44db8419abe98815c85bf4376d34
-|    +--- org.greenrobot:eventbus:3.3.1 (*)
-|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.9.2 (*)
-|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
-|    +--- androidx.paging:paging-runtime:2.1.2
-|    |    +--- androidx.paging:paging-common:2.1.2
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.1.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.1.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.3.1 (*)
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.2.0 (*)
-|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
-|    +--- com.goterl:lazysodium-android:5.0.2
-|    +--- net.java.dev.jna:jna:5.5.0
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
-|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10 (*)
-|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.3.1 (*)
-|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
-|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.1.0-beta01 (*)
-|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2
-|    |    +--- com.squareup.okhttp3:okhttp:4.9.2 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.6.10 (*)
-|    +--- com.google.code.gson:gson:2.8.5
-|    +--- org.apache.commons:commons-text:1.1 (*)
-|    +--- androidx.room:room-runtime:2.4.2 (*)
-|    +--- androidx.room:room-ktx:2.4.2
-|    |    +--- androidx.room:room-common:2.4.2 (*)
-|    |    +--- androidx.room:room-runtime:2.4.2 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
-|    +--- com.google.dagger:dagger:2.29.1 -> 2.41 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.5.2 (*)
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.5.2 (*)
++--- org.wordpress:fluxc:{strictly trunk-1ee442f447044438c9b17068cb224cc162cd5912} -> trunk-1ee442f447044438c9b17068cb224cc162cd5912
+|    +--- org.wordpress:wellsql:1.7.0
+|    |    \--- org.wordpress.wellsql:wellsql-annotations:1.7.0
+|    +--- org.wordpress.fluxc:fluxc-annotations:trunk-1ee442f447044438c9b17068cb224cc162cd5912
+|    +--- org.greenrobot:eventbus:3.3.1 (*)
+|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.9.2 (*)
+|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
+|    +--- androidx.paging:paging-runtime:2.1.2
+|    |    +--- androidx.paging:paging-common:2.1.2
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.1.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.1.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.3.1 (*)
+|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.2.0 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
+|    +--- com.goterl:lazysodium-android:5.0.2
+|    +--- net.java.dev.jna:jna:5.5.0
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
+|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10 (*)
+|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.3.1 (*)
+|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
+|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.1.0-beta01 (*)
+|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2
+|    |    +--- com.squareup.okhttp3:okhttp:4.9.2 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.6.10 (*)
+|    +--- com.google.code.gson:gson:2.8.5
+|    +--- org.apache.commons:commons-text:1.1 (*)
+|    +--- androidx.room:room-runtime:2.4.2 (*)
+|    +--- androidx.room:room-ktx:2.4.2
+|    |    +--- androidx.room:room-common:2.4.2 (*)
+|    |    +--- androidx.room:room-runtime:2.4.2 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+|    +--- com.google.dagger:dagger:2.29.1 -> 2.41 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.5.2 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.5.2 (*)
 \--- org.wordpress:login:0.14.0
-     \--- org.wordpress:fluxc:trunk-1436f46fc296ede0e65e117bbfced38fa34cec6d -> 2377-4413c7ddffab44db8419abe98815c85bf4376d34 (*)
+     \--- org.wordpress:fluxc:trunk-1436f46fc296ede0e65e117bbfced38fa34cec6d -> trunk-1ee442f447044438c9b17068cb224cc162cd5912 (*)

Please review and act accordingly

@ashiagr ashiagr merged commit b8fe0e2 into trunk May 6, 2022
[Android] Quick Start for Existing Users v2 automation moved this from Reviewer approved to Done May 6, 2022
@ashiagr ashiagr deleted the issue/16350-add-new-task-type-wpandroid branch May 6, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants