Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detekt - Resolve/Suppress All Baseline Warnings - max line warnings #17070

Conversation

Hoossayn
Copy link
Contributor

@Hoossayn Hoossayn commented Aug 23, 2022

Fixes #

This PR resolves/suppresses all style related warnings for the wordpress module:

10 x MaxLineLength (Resolve: ea0c46e)

I'm checking Baseline.xml file for files(or loc) that has max line warning and provide the appropriate fix.
you can see conversation #17010 (comment) for more info

To test:
Issue link -> #17010

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Hoossayn Hoossayn changed the title Analysis: Resolve max line length warnings Detekt - Resolve/Suppress All Baseline Warnings - max line warnings Aug 23, 2022
@Hoossayn Hoossayn marked this pull request as ready for review August 23, 2022 13:57
@ParaskP7 ParaskP7 self-requested a review September 13, 2022 12:28
@ParaskP7 ParaskP7 self-assigned this Sep 13, 2022
@ParaskP7 ParaskP7 added this to the Future milestone Sep 13, 2022
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @Hoossayn !

Thank you so much for this PR. This is your first-time contribution, awesome! 🎉

I have reviewed and tested this PR, along with triggering CI on it via a draft PR that I just pushed on the main repo (I did that on your behalf, since you can't do that yourself, being an external contributor and all).

Everything looks good and indeed there are no more MaxLineLength warnings within Detekt's baseline.xml file, thank you for that.

However, I did find a couple of minor (🔍) issues that I would love if you could take a look at before us merging this PR of yours. I also added a suggestion (💡) for you to consider.

Let me know how that works for your and we will progress with this PR accordingly.

@Hoossayn Hoossayn closed this Sep 16, 2022
@Hoossayn
Copy link
Contributor Author

new PR here -> #17164

@Hoossayn Hoossayn deleted the issue/17010-Detekt_Resolve/Suppress_All_Baseline_Warnings_max_line branch September 16, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants