-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detekt - Resolve/Suppress All Baseline Warnings - max line warnings #17070
Detekt - Resolve/Suppress All Baseline Warnings - max line warnings #17070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @Hoossayn !
Thank you so much for this PR. This is your first-time contribution, awesome! 🎉
I have reviewed and tested this PR, along with triggering CI on it via a draft PR that I just pushed on the main repo (I did that on your behalf, since you can't do that yourself, being an external contributor and all).
Everything looks good and indeed there are no more MaxLineLength
warnings within Detekt's baseline.xml
file, thank you for that.
However, I did find a couple of minor (🔍) issues that I would love if you could take a look at before us merging this PR of yours. I also added a suggestion (💡) for you to consider.
Let me know how that works for your and we will progress with this PR accordingly.
WordPress/src/main/java/org/wordpress/android/ui/posts/editor/XPostsCapabilityChecker.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/whatsnew/FeatureAnnouncementViewModel.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/util/config/AppConfig.kt
Outdated
Show resolved
Hide resolved
…ess_All_Baseline_Warnings_max_line' into issue/17010-Detekt_Resolve/Suppress_All_Baseline_Warnings_max_line
…ess_All_Baseline_Warnings_max_line' into issue/17010-Detekt_Resolve/Suppress_All_Baseline_Warnings_max_line
new PR here -> #17164 |
Fixes #
This PR resolves/suppresses all style related warnings for the wordpress module:
10
x MaxLineLength (Resolve: ea0c46e)I'm checking Baseline.xml file for files(or loc) that has max line warning and provide the appropriate fix.
you can see conversation #17010 (comment) for more info
To test:
Issue link -> #17010
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.