Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detekt - Resolve/Suppress All Baseline Warnings - Long methods warnings_ HomePageSettingsDialog #17468

Conversation

Hoossayn
Copy link
Contributor

@Hoossayn Hoossayn commented Nov 15, 2022

Parent: #17010

This PR resolves/suppresses all complexity related LongMethod warnings for the HomePageSettingsDialog class (see docs here):

1 x LongMethod (Resolve: f3bed1e + 605bcde + 796e490 )


To test:

  • There is nothing much to test here.

  • Verifying that all the CI checks are successful should be enough (especially the detekt check).

  • However, if you really want to be thorough, you could smoke test the WordPress and/or Jetpack apps to verify that everything works as expected on every screen that relates to these changes. Specifically, you could follow the below steps:

    • Go to the menu tab
    • Click on site settings
    • Select HomePage settings
    • Test that you can change between different homepage settings

Regression Notes

  1. Potential unintended areas of impact
    can't think of any

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    See To test section above.

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Hoossayn Hoossayn marked this pull request as ready for review November 15, 2022 11:49
@Hoossayn
Copy link
Contributor Author

👋🏾 @ParaskP7 kindly check this for the first part of the split PR

Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @Hoossayn !

Thank you so much for yet another contribution to WPAndroid with this PR! 🥇

I have reviewed and tested this PR as per the instructions, along with triggering CI on it via this #17470 PR, everything works as expected, good job! 🌟

@ParaskP7 ParaskP7 merged commit 1efab9e into wordpress-mobile:trunk Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants