[Dependency Updates] Reconfigure Media-for-Mobile Dependency

[ParaskP7]

This PR is mainly about reconfiguring the media-for-mobile dependency, in the sense of extracting its version (5cfcfd1), adding its transitive dependency directly (233ccde) and removing the unused M4mVideoOptimizer class (d40542d).

FYI: This media-for-mobile dependency was added as part of this PR (see 4a7c9c9 commit) for video optimization purposes (Cc @daniloercoli). Then, as part of this PR (see 61ebbbc commit), the unused M4mVideoOptimizer implementation was added as well, that is, along side the Mp4ComposerVideoOptimizer implementation.

This change will help with maintaining and updating this media-for-mobile dependency. Also, opening this PR gives me the opportunity to ask a couple of questions about this library, its maintenance and implementation overall:

1. @daniloercoli since you were the last to contribute to the media-for-mobile project (Jun 15, 2017), what's the state of this project, should it be considered outdated, should we start maintaining it more actively. Also, this project is under the INDExOS umbrella, I am not sure what that means, can you shed some light on that too? 🤔
2. @develric since you were the one that added this unused M4mVideoOptimizer implementation. Is that really as unused as it seems, is there a reason for that, is it safe to remove this implementation? 🤔

---

PS: @develric I added you as the main reviewer, that is, in addition to the @wordpress-mobile/apps-infrastructure team itself, but not entirely randomly as I am seeing you having some experience on working with video optimization, and want someone from the WordPress team to be aware of and sign-off on that change for WPAndroid.

---

To test:

1. See the dependency tree diff result and verify correctness.
2. Smoke test any video optimization related functionality on both, the WordPress and Jetpack apps, and see if they both work as expected. For more info on how to test the video optimization you can follow the testing instructions on this Using stories lib in video compression scenario #14256 PR.

---

Regression Notes

1. Potential unintended areas of impact

   • The media-for-mobile:domain transitive dependency added might be causing some kind of misbehaviour.

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • See To test section above.

3. What automated tests I added (or what prevented me from doing so)

   • N/A

---

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

Found 1 violations:

The PR caused the following dependency changes:

+\--- com.github.indexos.media-for-mobile:domain:43a9026f0973a2f0a74fa813132f6a16f7499c3a

Please review and act accordingly

[wpmobilebot]

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17903-124aead.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	WordPress
	Build Flavor	Jalapeno
	Build Type	Debug
	Commit	124aead

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

[wpmobilebot]

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17903-124aead.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	Jetpack
	Build Flavor	Jalapeno
	Build Type	Debug
	Commit	124aead

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

[develric]

Hey @ParaskP7 👋 , you are bringing me back to a looong time ago 😄. This internal post should link a bit the dots (p2-pbArwn-2gH). The TL;DR being that I think the reason for starting using the compression embedded in the stories lib was because of a crash issue with the m4m library that is not maintained actively and the original contribution fix o that library never got merged by the repo owners.

I'm not sure I can deeper help on this soon-ish (not this week at least) but I see you are targeting the "Future" milestone so hopefully this is not super urgent and I can join the party next sprint. Gut feeling I agree it should be possible to remove the M4mVideoOptimizer that I think was added to uniform the approach with the Mp4ComposerVideoOptimizer but apparently is not used any more as you say 🤔 . Hope this at least helps clarify the context meanwhile 🙇

[ParaskP7]

👋 @develric !

Hey @ParaskP7 👋 , you are bringing me back to a looong time ago 😄.

I know right! 😄

This internal post should link a bit the dots (p2-pbArwn-2gH). The TL;DR being that I think the reason for starting using the compression embedded in the stories lib was because of a crash issue with the m4m library that is not maintained actively and the original INDExOS/media-for-mobile#100 o that library never got merged by the repo owners.

Thanks so much for adding some context here, much appreciated! 💯

I'm not sure I can deeper help on this soon-ish (not this week at least) but I see you are targeting the "Future" milestone so hopefully this is not super urgent and I can join the party next sprint.

Definitely, reviewing and testing this PR is not urgent, so please take your time with it, next week or otherwise. No matter, thanks so much for the heads-up on your availability. 👍

FYI: The changes in this PR is mainly M4mVideoOptimizer related so I think just verifying that is unused should do it.

PS: We might also take the opportunity to see how to move forward with media-for-mobile as it seems that at some point we might be forced, at least maintainability-wise. 🤔

Gut feeling I agree it should be possible to remove the M4mVideoOptimizer that I think was added to uniform the approach with the Mp4ComposerVideoOptimizer but apparently is not used any more as you say 🤔 .

Got it! 👍

Hope this at least helps clarify the context meanwhile 🙇

Definitely helps, thank you Riccardo! 🙇

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr17903-da8bc30
	Commit	da8bc30
	Direct Download	wordpress-prototype-build-pr17903-da8bc30.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr17903-da8bc30
	Commit	da8bc30
	Direct Download	jetpack-prototype-build-pr17903-da8bc30.apk

Note: Google Login is not supported on these builds.

[develric]

Hey @ParaskP7 👋 ! This LGTM. I tested adding videos in WP and JP with/without video compression from Media Library, and Editor.

PS: about the M4mVideoOptimizer class, I think I confirm my gut feeling. I guess the common base part was extracted from VideoOptimizer into VideoOptimizerBase and aiming to in principle support different video compressors the specifics were enforced into Mp4ComposerVideoOptimizer and (for analogy) M4mVideoOptimizer. Since this last is not currently used, I think makes sense to remove it as you did (we still have the Mp4ComposerVideoOptimizer that can serve as an implementation reference if ever needed)

[ParaskP7]

Hey @ParaskP7 👋 ! This LGTM. I tested adding videos in WP and JP with/without video compression from Media Library, and Editor.

Thanks so much for review and testing this @develric , much appreciated! 🙇 ❤️ 🚀

PS: about the M4mVideoOptimizer class, I think I confirm my gut feeling. I guess the common base part was extracted from VideoOptimizer into VideoOptimizerBase and aiming to in principle support different video compressors the specifics were enforced into Mp4ComposerVideoOptimizer and (for analogy) M4mVideoOptimizer. Since this last is not currently used, I think makes sense to remove it as you did (we still have the Mp4ComposerVideoOptimizer that can serve as an implementation reference if ever needed)

Great, thanks so much for the confirmation and clarification on that, bye bye M4mVideoOptimizer, see you on the other side! 👋 😅 👋