Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/17260 wordpress module asynctask warning commentdetailactivity #18480

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

shifli7
Copy link

@shifli7 shifli7 commented May 21, 2023

Fixes #17260

To test:

  1. Open App and Login
  2. Go to My Site tab
  3. Select Comments in home
  4. In Comments page there is list of comments
  5. Open anyone of the comment
  6. Swipe left and right to go previous and next comment
  7. Replay or Like or marked as spam the comment
  8. Check it updating

Regression Notes

  1. Potential unintended areas of impact
    Comments screen and it's functionality

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually test this page. Working good.

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • Talkback.
  • High contrast.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: See comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler Warnings as Errors - WordPress Module - AsyncTask
2 participants