Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a debug screen for displaying all shared pref flags #19880

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

justtwago
Copy link
Member

@justtwago justtwago commented Jan 3, 2024

Created a screen for internal purposes to display and modify saved local flags. It's available on the debug settings screen

PS: I'm open to a better name for the screen 馃槃


To Test:

  • Launch a debug app
  • Go to Me -> Debug settings
  • Open a dropdown menu on the toolbar and tap on All local flags
  • Make sure you can see your locally saved boolean flags from shared prefs
  • Modify any and make sure the new value is saved

Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn鈥檛 complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@peril-wordpress-mobile
Copy link

Warnings
鈿狅笍 PR is not assigned to a milestone.

Generated by 馃毇 dangerJS

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 3, 2024

WordPress馃摬 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19880-5f86b5d
Commit5f86b5d
Direct Downloadwordpress-prototype-build-pr19880-5f86b5d.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 3, 2024

Jetpack馃摬 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19880-5f86b5d
Commit5f86b5d
Direct Downloadjetpack-prototype-build-pr19880-5f86b5d.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @justtwago

The changes look good to me, approving but not merging so that others can have a look

馃挕 Suggestion: Change the naming to Preferences or Shared Preferences.

@justtwago justtwago changed the title Create a debug screen for displaying all local flags Create a debug screen for displaying all shared pref flags Jan 5, 2024
@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Jan 9, 2024
@justtwago justtwago merged commit 54367bc into trunk Jan 9, 2024
20 checks passed
@justtwago justtwago deleted the debug-local-flags-screen branch January 9, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants