fix #985 make sFactory private in factories #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxme
commented
Nov 20, 2014
maxme
commented
- fix Make sFactory members private and prevent call to the setter in non test mode #985 make sFactory private in factories
- UI tests are unusable, so I removed all of them
- fix WPHtml test
| import java.net.URI; | ||
|
|
||
| public class XMLRPCFactory { | ||
| public static XMLRPCFactoryAbstract sFactory; | ||
| private static XMLRPCFactoryAbstract sFactory; | ||
|
|
||
| public static XMLRPCClientInterface instantiate(URI uri, String httpUser, String httpPassword) { | ||
| if (sFactory == null) { | ||
| sFactory = new XMLRPCFactoryDefault(); |
There was a problem hiding this comment.
Should we move this (and others like it) to a static initializer?
Good discussion here.
…ctory-private Conflicts: WordPress/src/androidTest/java/org/wordpress/android/ActivityRobotiumTestCase.java
|
I tested this by running the "connectedCheck" task and saw this: https://cloudup.com/cosWi_l8fv1 |
|
@nbradbury needs another review, tests are failing for the WordPressComRest subproject. To run tests for the WordPress project only: |
|
That worked |
nbradbury
added a commit
that referenced
this pull request
Dec 16, 2014
…y-private fix #985 make sFactory private in factories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.